Improve code to phpstan level 8

Author: DigitalTimK

phpstan.neon

@@ -1,5 +1,5 @@
 parameters:
-    level: 7
+    level: 8
     paths:
         - src/
         - tests/

src/Core/Image.php

@@ -32,7 +32,7 @@ class Image
 
     public function __construct(\SimpleXMLElement $xml)
     {
-        $this->alt    = $xml['alt']->__toString();
+        $this->alt    = $xml['alt'] ? $xml['alt']->__toString() : '';
         $this->height = (int) $xml['height'];
         $this->width  = (int) $xml['width'];
         $this->url    = $xml->__toString();

src/Parameters/CreateMeetingParameters.php

@@ -418,7 +418,7 @@ public function setAllowStartStopRecording(bool $allowStartStopRecording): self
         return $this;
     }
 
-    public function getDuration(): int
+    public function getDuration(): ?int
     {
         return $this->duration;
     }
@@ -572,7 +572,7 @@ public function setLearningDashboardEnabled(bool $learningDashboardEnabled): sel
     /**
      * @deprecated Removed in 2.5, temporarily still handled, please transition to disabledFeatures.
      */
-    public function isVirtualBackgroundsDisabled(): bool
+    public function isVirtualBackgroundsDisabled(): ?bool
     {
         return $this->virtualBackgroundsDisabled;
     }
@@ -867,7 +867,7 @@ public function setLockSettingsLockOnJoinConfigurable(bool $lockOnJoinConfigurab
         return $this;
     }
 
-    public function isLockSettingsHideViewersCursor(): bool
+    public function isLockSettingsHideViewersCursor(): ?bool
     {
         return $this->lockSettingsHideViewersCursor;
     }
@@ -905,7 +905,7 @@ public function setAllowModsToUnmuteUsers(bool $allowModsToUnmuteUsers): self
         return $this;
     }
 
-    public function isAllowModsToEjectCameras(): bool
+    public function isAllowModsToEjectCameras(): ?bool
     {
         return $this->allowModsToEjectCameras;
     }
@@ -1026,7 +1026,7 @@ public function setGuestPolicy(string $guestPolicy): self
     /**
      * @deprecated Removed in 2.5, temporarily still handled, please transition to disabledFeatures.
      */
-    public function isBreakoutRoomsEnabled(): bool
+    public function isBreakoutRoomsEnabled(): ?bool
     {
         return $this->breakoutRoomsEnabled;
     }
@@ -1047,7 +1047,7 @@ public function setBreakoutRoomsEnabled($breakoutRoomsEnabled): self
         return $this;
     }
 
-    public function isBreakoutRoomsRecord(): bool
+    public function isBreakoutRoomsRecord(): ?bool
     {
         return $this->breakoutRoomsRecord;
     }
@@ -1081,7 +1081,7 @@ public function setBreakoutRoomsPrivateChatEnabled(bool $breakoutRoomsPrivateCha
         return $this;
     }
 
-    public function getMeetingEndedURL(): string
+    public function getMeetingEndedURL(): ?string
     {
         return $this->meetingEndedURL;
     }
@@ -1154,7 +1154,7 @@ public function setUserCameraCap(int $userCameraCap): self
         return $this;
     }
 
-    public function getMeetingCameraCap(): int
+    public function getMeetingCameraCap(): ?int
     {
         return $this->meetingCameraCap;
     }
@@ -1174,7 +1174,7 @@ public function setMeetingCameraCap(int $meetingCameraCap): self
         return $this;
     }
 
-    public function getMeetingExpireIfNoUserJoinedInMinutes(): int
+    public function getMeetingExpireIfNoUserJoinedInMinutes(): ?int
     {
         return $this->meetingExpireIfNoUserJoinedInMinutes;
     }
@@ -1193,7 +1193,7 @@ public function setMeetingExpireIfNoUserJoinedInMinutes(int $meetingExpireIfNoUs
         return $this;
     }
 
-    public function getMeetingExpireWhenLastUserLeftInMinutes(): int
+    public function getMeetingExpireWhenLastUserLeftInMinutes(): ?int
     {
         return $this->meetingExpireWhenLastUserLeftInMinutes;
     }
@@ -1214,7 +1214,7 @@ public function setMeetingExpireWhenLastUserLeftInMinutes(int $meetingExpireWhen
         return $this;
     }
 
-    public function isPreUploadedPresentationOverrideDefault(): bool
+    public function isPreUploadedPresentationOverrideDefault(): ?bool
     {
         return $this->preUploadedPresentationOverrideDefault;
     }
@@ -1301,7 +1301,7 @@ public function setDisabledFeaturesExclude(array $disabledFeaturesExclude): self
         return $this;
     }
 
-    public function getRecordFullDurationMedia(): bool
+    public function getRecordFullDurationMedia(): ?bool
     {
         return $this->recordFullDurationMedia;
     }
@@ -1342,7 +1342,7 @@ public function addBreakoutRoomsGroup($id, $name, $roster): self
         return $this;
     }
 
-    public function getNotifyRecordingIsOn(): bool
+    public function getNotifyRecordingIsOn(): ?bool
     {
         return $this->notifyRecordingIsOn;
     }
@@ -1362,7 +1362,7 @@ public function setNotifyRecordingIsOn(bool $notifyRecordingIsOn): self
         return $this;
     }
 
-    public function getPresentationUploadExternalUrl(): string
+    public function getPresentationUploadExternalUrl(): ?string
     {
         return $this->presentationUploadExternalUrl;
     }
@@ -1380,7 +1380,7 @@ public function setPresentationUploadExternalUrl(string $presentationUploadExter
         return $this;
     }
 
-    public function getPresentationUploadExternalDescription(): string
+    public function getPresentationUploadExternalDescription(): ?string
     {
         return $this->presentationUploadExternalDescription;
     }
@@ -1414,8 +1414,8 @@ public function getHTTPQuery(): string
             'maxParticipants'                        => $this->maxParticipants,
             'autoStartRecording'                     => !is_null($this->autoStartRecording) ? ($this->autoStartRecording ? 'true' : 'false') : $this->autoStartRecording,
             'allowStartStopRecording'                => !is_null($this->allowStartStopRecording) ? ($this->allowStartStopRecording ? 'true' : 'false') : $this->allowStartStopRecording,
-            'welcome'                                => trim($this->welcomeMessage),
-            'moderatorOnlyMessage'                   => trim($this->moderatorOnlyMessage),
+            'welcome'                                => !is_null($this->welcomeMessage) ? trim($this->welcomeMessage) : '',
+            'moderatorOnlyMessage'                   => !is_null($this->moderatorOnlyMessage) ? trim($this->moderatorOnlyMessage) : '',
             'webcamsOnlyForModerator'                => !is_null($this->webcamsOnlyForModerator) ? ($this->webcamsOnlyForModerator ? 'true' : 'false') : $this->webcamsOnlyForModerator,
             'logo'                                   => $this->logo,
             'copyright'                              => $this->copyright,
@@ -1433,8 +1433,8 @@ public function getHTTPQuery(): string
             'lockSettingsHideViewersCursor'          => !is_null($this->lockSettingsHideViewersCursor) ? ($this->lockSettingsHideViewersCursor ? 'true' : 'false') : $this->lockSettingsHideViewersCursor,
             'allowModsToUnmuteUsers'                 => !is_null($this->allowModsToUnmuteUsers) ? ($this->allowModsToUnmuteUsers ? 'true' : 'false') : $this->allowModsToUnmuteUsers,
             'allowModsToEjectCameras'                => !is_null($this->allowModsToEjectCameras) ? ($this->allowModsToEjectCameras ? 'true' : 'false') : $this->allowModsToEjectCameras,
-            'bannerText'                             => trim($this->bannerText),
-            'bannerColor'                            => trim($this->bannerColor),
+            'bannerText'                             => !is_null($this->bannerText) ? trim($this->bannerText) : '',
+            'bannerColor'                            => !is_null($this->bannerColor) ? trim($this->bannerColor) : '',
             'learningDashboardEnabled'               => !is_null($this->learningDashboardEnabled) ? ($this->learningDashboardEnabled ? 'true' : 'false') : $this->learningDashboardEnabled,
             'virtualBackgroundsDisabled'             => !is_null($this->virtualBackgroundsDisabled) ? ($this->virtualBackgroundsDisabled ? 'true' : 'false') : $this->virtualBackgroundsDisabled,
             'endWhenNoModeratorDelayInMinutes'       => $this->endWhenNoModeratorDelayInMinutes,

src/Parameters/DeleteRecordingsParameters.php

@@ -27,40 +27,24 @@ class DeleteRecordingsParameters extends BaseParameters
 {
     private ?string $recordingId = null;
 
-    /**
-     * DeleteRecordingsParameters constructor.
-     *
-     * @param mixed $recordingId
-     */
-    public function __construct($recordingId = null)
+    public function __construct(string $recordingId = null)
     {
         $this->recordingId = $recordingId;
     }
 
-    /**
-     * @return string
-     */
-    public function getRecordingId()
+    public function getRecordingId(): ?string
     {
         return $this->recordingId;
     }
 
-    /**
-     * @param string $recordingId
-     *
-     * @return DeleteRecordingsParameters
-     */
-    public function setRecordingId($recordingId)
+    public function setRecordingId(string $recordingId): DeleteRecordingsParameters
     {
         $this->recordingId = $recordingId;
 
         return $this;
     }
 
-    /**
-     * @return string
-     */
-    public function getHTTPQuery()
+    public function getHTTPQuery(): string
     {
         return $this->buildHTTPQuery(['recordID' => $this->recordingId]);
     }

src/Parameters/EndMeetingParameters.php

@@ -32,32 +32,18 @@ class EndMeetingParameters extends BaseParameters
      */
     private ?string $password = null;
 
-    /**
-     * EndMeetingParameters constructor.
-     *
-     * @param string $meetingId
-     * @param string $password
-     */
-    public function __construct($meetingId = null, $password = null)
+    public function __construct(string $meetingId = null, string $password = null)
     {
         $this->password  = $password;
         $this->meetingId = $meetingId;
     }
 
-    /**
-     * @return string
-     */
-    public function getMeetingId()
+    public function getMeetingId(): ?string
     {
         return $this->meetingId;
     }
 
-    /**
-     * @param string $meetingId
-     *
-     * @return EndMeetingParameters
-     */
-    public function setMeetingId($meetingId)
+    public function setMeetingId(string $meetingId): self
     {
         $this->meetingId = $meetingId;
 
@@ -66,32 +52,23 @@ public function setMeetingId($meetingId)
 
     /**
      * @deprecated
-     *
-     * @return string
      */
-    public function getPassword()
+    public function getPassword(): ?string
     {
         return $this->password;
     }
 
     /**
-     * @param string $password
-     *
      * @deprecated
-     *
-     * @return EndMeetingParameters
      */
-    public function setPassword($password)
+    public function setPassword(string $password): self
     {
         $this->password = $password;
 
         return $this;
     }
 
-    /**
-     * @return string
-     */
-    public function getHTTPQuery()
+    public function getHTTPQuery(): string
     {
         return $this->buildHTTPQuery(
             [

src/Parameters/GetMeetingInfoParameters.php

@@ -36,7 +36,7 @@ public function __construct(?string $meetingId = null)
         $this->meetingId = $meetingId;
     }
 
-    public function getMeetingId(): string
+    public function getMeetingId(): ?string
     {
         return $this->meetingId;
     }

src/Parameters/GetRecordingTextTracksParameters.php

@@ -29,38 +29,25 @@ class GetRecordingTextTracksParameters extends MetaParameters
 
     /**
      * GetRecordingTextTracksParameters constructor.
-     *
-     * @param mixed $recordId
      */
-    public function __construct($recordId = null)
+    public function __construct(string $recordId = null)
     {
         $this->recordId = $recordId;
     }
 
-    /**
-     * @return string
-     */
-    public function getRecordId()
+    public function getRecordId(): ?string
     {
         return $this->recordId;
     }
 
-    /**
-     * @param string $recordId
-     *
-     * @return GetRecordingTextTracksParameters
-     */
-    public function setRecordId($recordId)
+    public function setRecordId(string $recordId): self
     {
         $this->recordId = $recordId;
 
         return $this;
     }
 
-    /**
-     * @return string
-     */
-    public function getHTTPQuery()
+    public function getHTTPQuery(): string
     {
         $queries = [
             'recordID' => $this->recordId,