Skip to content

Commit 856eeff

Browse files
committed
Improve documentation.
1 parent 0624b41 commit 856eeff

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

src/BigBlueButton.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -356,6 +356,7 @@ public function updateRecordings($recordingParams)
356356
*
357357
* @param string $url
358358
* @param string $payload
359+
* @param string $contentType
359360
* @return SimpleXMLElement
360361
* @throws \RuntimeException
361362
*/

src/Core/Meeting.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class Meeting
3636
private $meetingName;
3737

3838
/**
39-
* @var int
39+
* @var double
4040
*/
4141
private $creationTime;
4242

tests/BigBlueButtonTest.php

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,9 @@ public function testCreateMeetingUrl()
7676
$params = $this->generateCreateParams();
7777
$url = $this->bbb->getCreateMeetingUrl($this->getCreateMock($params));
7878
foreach ($params as $key => $value) {
79-
$value = !is_bool($value) ? $value : ($value === true ? 'true' : 'false');
79+
if (is_bool($value)) {
80+
$value = $value ? 'true' : 'false';
81+
}
8082
$this->assertContains('=' . urlencode($value), $url);
8183
}
8284
}
@@ -132,7 +134,9 @@ public function testCreateJoinMeetingUrl()
132134
$url = $this->bbb->getJoinMeetingURL($joinMeetingMock);
133135

134136
foreach ($joinMeetingParams as $key => $value) {
135-
$value = !is_bool($value) ? $value : ($value ? 'true' : 'false');
137+
if (is_bool($value)) {
138+
$value = $value ? 'true' : 'false';
139+
}
136140
$this->assertContains('=' . urlencode($value), $url);
137141
}
138142
}
@@ -310,7 +314,9 @@ public function testUpdateRecordingsUrl()
310314
$params = $this->generateUpdateRecordingsParams();
311315
$url = $this->bbb->getUpdateRecordingsUrl($this->getUpdateRecordingsParamsMock($params));
312316
foreach ($params as $key => $value) {
313-
$value = !is_bool($value) ? $value : ($value ? 'true' : 'false');
317+
if (is_bool($value)) {
318+
$value = $value ? 'true' : 'false';
319+
}
314320
$this->assertContains('=' . urlencode($value), $url);
315321
}
316322
}

0 commit comments

Comments
 (0)