Skip to content

Commit 92c3706

Browse files
authored
Merge pull request #60 from jibon57/master
Added bbb-recording-ready-url
2 parents f37dd93 + ed375bc commit 92c3706

File tree

3 files changed

+16
-3
lines changed

3 files changed

+16
-3
lines changed

src/Parameters/CreateMeetingParameters.php

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -753,7 +753,18 @@ public function setLockSettingsLockOnJoinConfigurable($lockOnJoinConfigurable)
753753
*/
754754
public function setEndCallbackUrl($endCallbackUrl)
755755
{
756-
$this->addMeta('endCallbackUrl', $endCallbackUrl);
756+
$this->addMeta('endCallbackUrl', urlencode($endCallbackUrl));
757+
758+
return $this;
759+
}
760+
761+
/**
762+
* @param $recordingReadyCallbackUrl
763+
* @return CreateMeetingParameters
764+
*/
765+
public function setRecordingReadyCallbackUrl($recordingReadyCallbackUrl)
766+
{
767+
$this->addMeta('bbb-recording-ready-url', urlencode($recordingReadyCallbackUrl));
757768

758769
return $this;
759770
}

tests/Parameters/CreateMeetingParametersTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ public function testCreateMeetingParameters()
6060
$this->assertEquals($params['lockSettingsLockOnJoin'], $createMeetingParams->isLockSettingsLockOnJoin());
6161
$this->assertEquals($params['lockSettingsLockOnJoinConfigurable'], $createMeetingParams->isLockSettingsLockOnJoinConfigurable());
6262
$this->assertEquals($params['meta_presenter'], $createMeetingParams->getMeta('presenter'));
63-
$this->assertEquals($params['meta_endCallbackUrl'], $createMeetingParams->getMeta('endCallbackUrl'));
63+
$this->assertEquals($params['meta_endCallbackUrl'], urlencode($createMeetingParams->getMeta('endCallbackUrl')));
64+
$this->assertEquals($params['meta_bbb-recording-ready-url'], urlencode($createMeetingParams->getMeta('bbb-recording-ready-url')));
6465

6566
// Check values are empty of this is not a breakout room
6667
$this->assertNull($createMeetingParams->isBreakout());

tests/TestCase.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,8 @@ protected function generateCreateParams()
9696
'lockSettingsLockOnJoin' => $this->faker->boolean(50),
9797
'lockSettingsLockOnJoinConfigurable' => $this->faker->boolean(50),
9898
'meta_presenter' => $this->faker->name,
99-
'meta_endCallbackUrl' => $this->faker->url
99+
'meta_endCallbackUrl' => $this->faker->url,
100+
'meta_bbb-recording-ready-url' => $this->faker->url,
100101
];
101102
}
102103

0 commit comments

Comments
 (0)