Skip to content

Commit c47446c

Browse files
committed
Solve bug reported by scrutinizer
1 parent bc31694 commit c47446c

File tree

5 files changed

+27
-33
lines changed

5 files changed

+27
-33
lines changed

src/Core/Meeting.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,9 @@ public function getAttendees(): array
226226
$attendees = [];
227227

228228
foreach ($this->rawXml->attendees->attendee as $attendeeXml) {
229-
$attendees[] = new Attendee($attendeeXml);
229+
if ($attendeeXml) {
230+
$attendees[] = new Attendee($attendeeXml);
231+
}
230232
}
231233

232234
return $attendees;

src/Core/Record.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,9 @@ public function getFormats(): array
149149
$formats = [];
150150

151151
foreach ($this->rawXml->playback->format as $formatXml) {
152-
$formats[] = new Format($formatXml);
152+
if ($formatXml) {
153+
$formats[] = new Format($formatXml);
154+
}
153155
}
154156

155157
return $formats;

src/Responses/GetMeetingsResponse.php

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,23 +27,19 @@
2727
*/
2828
class GetMeetingsResponse extends BaseResponse
2929
{
30-
/**
31-
* @var Meeting[]
32-
*/
33-
private $meetings;
34-
3530
/**
3631
* @return Meeting[]
3732
*/
38-
public function getMeetings()
33+
public function getMeetings(): array
3934
{
40-
if (null === $this->meetings) {
41-
$this->meetings = [];
42-
foreach ($this->rawXml->meetings->children() as $meetingXml) {
43-
$this->meetings[] = new Meeting($meetingXml);
35+
$meetings = [];
36+
37+
foreach ($this->rawXml->meetings->children() as $meetingXml) {
38+
if ($meetingXml) {
39+
$meetings[] = new Meeting($meetingXml);
4440
}
4541
}
4642

47-
return $this->meetings;
43+
return $meetings;
4844
}
4945
}

src/Responses/GetRecordingsResponse.php

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,23 +27,20 @@
2727
*/
2828
class GetRecordingsResponse extends BaseResponse
2929
{
30-
/**
31-
* @var Record[]
32-
*/
33-
private $records;
3430

3531
/**
3632
* @return Record[]
3733
*/
38-
public function getRecords()
34+
public function getRecords(): array
3935
{
40-
if (null === $this->records) {
41-
$this->records = [];
42-
foreach ($this->rawXml->recordings->children() as $recordXml) {
43-
$this->records[] = new Record($recordXml);
36+
$records = [];
37+
38+
foreach ($this->rawXml->recordings->children() as $recordXml) {
39+
if ($recordXml) {
40+
$records[] = new Record($recordXml);
4441
}
4542
}
4643

47-
return $this->records;
44+
return $records;
4845
}
4946
}

src/Responses/HooksListResponse.php

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,23 +27,20 @@
2727
*/
2828
class HooksListResponse extends BaseResponse
2929
{
30-
/**
31-
* @var Hook[]
32-
*/
33-
private $hooks;
3430

3531
/**
3632
* @return Hook[]
3733
*/
38-
public function getHooks()
34+
public function getHooks(): array
3935
{
40-
if (null === $this->hooks) {
41-
$this->hooks = [];
42-
foreach ($this->rawXml->hooks->children() as $hookXml) {
43-
$this->hooks[] = new Hook($hookXml);
36+
$hooks = [];
37+
38+
foreach ($this->rawXml->hooks->children() as $hookXml) {
39+
if ($hookXml) {
40+
$hooks[] = new Hook($hookXml);
4441
}
4542
}
4643

47-
return $this->hooks;
44+
return $hooks;
4845
}
4946
}

0 commit comments

Comments
 (0)