Skip to content

Commit f167def

Browse files
committed
Deprecate password params and new enum classes.
1 parent ed2e7c2 commit f167def

File tree

5 files changed

+60
-7
lines changed

5 files changed

+60
-7
lines changed

src/Enum/Feature.php

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
<?php
2+
3+
/*
4+
* BigBlueButton open source conferencing system - https://www.bigbluebutton.org/.
5+
*
6+
* Copyright (c) 2016-2022 BigBlueButton Inc. and by respective authors (see below).
7+
*
8+
* This program is free software; you can redistribute it and/or modify it under the
9+
* terms of the GNU Lesser General Public License as published by the Free Software
10+
* Foundation; either version 3.0 of the License, or (at your option) any later
11+
* version.
12+
*
13+
* BigBlueButton is distributed in the hope that it will be useful, but WITHOUT ANY
14+
* WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A
15+
* PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details.
16+
*
17+
* You should have received a copy of the GNU Lesser General Public License along
18+
* with BigBlueButton; if not, see <http://www.gnu.org/licenses/>.
19+
*/
20+
21+
namespace BigBlueButton\Enum;
22+
23+
use MabeEnum\Enum;
24+
25+
class Feature extends Enum
26+
{
27+
public const BREAKOUT_ROOMS = 'breakoutRooms';
28+
public const CAPTIONS = 'captions';
29+
public const CHAT = 'chat';
30+
public const EXTERNAL_VIDEOS = 'externalVideos';
31+
public const LAYOUTS = 'layouts';
32+
public const LEARNING_DASHBOARD = 'learningDashboard';
33+
public const POLLS = 'polls';
34+
public const SCREENSHARE = 'screenshare';
35+
public const SHARED_NOTES = 'sharedNotes';
36+
public const VIRTUAL_BACKGROUNDS = 'virtualBackgrounds';
37+
}
Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,11 @@
1818
* with BigBlueButton; if not, see <http://www.gnu.org/licenses/>.
1919
*/
2020

21-
namespace BigBlueButton\Core;
21+
namespace BigBlueButton\Enum;
2222

23-
class GuestPolicy
23+
use MabeEnum\Enum;
24+
25+
class GuestPolicy extends Enum
2426
{
2527
public const ALWAYS_ACCEPT = 'ALWAYS_ACCEPT';
2628
public const ALWAYS_DENY = 'ALWAYS_DENY';

src/Parameters/CreateMeetingParameters.php

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,6 @@
2525
*/
2626
class CreateMeetingParameters extends MetaParameters
2727
{
28-
public const ALWAYS_ACCEPT = 'ALWAYS_ACCEPT';
29-
public const ALWAYS_DENY = 'ALWAYS_DENY';
30-
public const ASK_MODERATOR = 'ASK_MODERATOR';
31-
3228
/**
3329
* @var string
3430
*/
@@ -41,11 +37,15 @@ class CreateMeetingParameters extends MetaParameters
4137

4238
/**
4339
* @var string
40+
*
41+
* @deprecated
4442
*/
4543
private $attendeePassword;
4644

4745
/**
4846
* @var string
47+
*
48+
* @deprecated
4949
*/
5050
private $moderatorPassword;
5151

@@ -323,6 +323,8 @@ public function setMeetingName($meetingName)
323323

324324
/**
325325
* @return string
326+
*
327+
* @deprecated
326328
*/
327329
public function getAttendeePassword()
328330
{
@@ -332,6 +334,8 @@ public function getAttendeePassword()
332334
/**
333335
* @param string $attendeePassword
334336
*
337+
* @deprecated
338+
*
335339
* @return CreateMeetingParameters
336340
*/
337341
public function setAttendeePassword($attendeePassword)
@@ -342,6 +346,8 @@ public function setAttendeePassword($attendeePassword)
342346
}
343347

344348
/**
349+
* @deprecated
350+
*
345351
* @return string
346352
*/
347353
public function getModeratorPassword()
@@ -352,6 +358,8 @@ public function getModeratorPassword()
352358
/**
353359
* @param string $moderatorPassword
354360
*
361+
* @deprecated
362+
*
355363
* @return CreateMeetingParameters
356364
*/
357365
public function setModeratorPassword($moderatorPassword)

src/Parameters/JoinMeetingParameters.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ class JoinMeetingParameters extends UserDataParameters
3737

3838
/**
3939
* @var string
40+
*
41+
* @deprecated
4042
*/
4143
private $password;
4244

@@ -136,6 +138,8 @@ public function setUsername($username)
136138
}
137139

138140
/**
141+
* @deprecated
142+
*
139143
* @return string
140144
*/
141145
public function getPassword()
@@ -146,6 +150,8 @@ public function getPassword()
146150
/**
147151
* @param string $password
148152
*
153+
* @deprecated
154+
*
149155
* @return JoinMeetingParameters
150156
*/
151157
public function setPassword($password)

tests/TestCase.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020

2121
namespace BigBlueButton;
2222

23-
use BigBlueButton\Core\GuestPolicy;
2423
use BigBlueButton\Core\MeetingLayout;
24+
use BigBlueButton\Enum\GuestPolicy;
2525
use BigBlueButton\Parameters\CreateMeetingParameters;
2626
use BigBlueButton\Parameters\EndMeetingParameters;
2727
use BigBlueButton\Parameters\JoinMeetingParameters;

0 commit comments

Comments
 (0)