Fix the error with accessing a non-existent attribute in the config #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Any review, pease 🙏 Logs with |
Jesterovskiy
approved these changes
Nov 10, 2021
| require_relative 'simplecov_helper' | ||
| require 'bigcommerce/prometheus' | ||
| require 'pry' | ||
| require 'rails' |
Member
There was a problem hiding this comment.
This gem is used in non-rails systems, so we shouldn't pull in this dependency here.
| spec.add_development_dependency 'bundler-audit', '>= 0.6' | ||
| spec.add_development_dependency 'null-logger', '>= 0.1' | ||
| spec.add_development_dependency 'pry', '>= 0.12' | ||
| spec.add_development_dependency 'railties', '>= 6.0.0' |
Member
There was a problem hiding this comment.
This gem supports Rails 5.2+, so we'll need to not limit this to 6.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes
before_fork_callbacks,after_fork_callbacks) in the config: when checking the value for nil, we can get aNoMethodErrorif no one has set this attribute before.