Add options to NewWithDefaults, update bool (#20)

* Add supprt for options in NewWithDefaults
* Make getting boolean values case-insensitive, i.e. "yes", "true", "on", "True", "ON" are all considered to be `true`.

Author: emar-kar

configparser.go

@@ -91,8 +91,8 @@ func NewWithOptions(opts ...optFunc) *ConfigParser {
 }
 
 // NewWithDefaults allows creation of a new ConfigParser with a pre-existing Dict.
-func NewWithDefaults(defaults Dict) (*ConfigParser, error) {
-	p := New()
+func NewWithDefaults(defaults Dict, opts ...optFunc) (*ConfigParser, error) {
+	p := NewWithOptions(opts...)
 	for key, value := range defaults {
 		// Add never returns an error.
 		_ = p.defaults.Add(key, value)

methods.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"sort"
 	"strconv"
+	"strings"
 )
 
 func (p *ConfigParser) isDefaultSection(section string) bool {
@@ -16,8 +17,9 @@ func (p *ConfigParser) Defaults() Dict {
 }
 
 // Sections returns a list of section names, excluding [DEFAULT].
+// Returned slice is sorted.
 func (p *ConfigParser) Sections() []string {
-	sections := make([]string, 0)
+	sections := make([]string, 0, len(p.config))
 	for section := range p.config {
 		sections = append(sections, section)
 	}
@@ -54,7 +56,8 @@ func (p *ConfigParser) HasSection(section string) bool {
 	return present
 }
 
-// Options returns a list of option mames for the given section name.
+// Options returns a list of option names for the given section name.
+// Returned slice is sorted.
 //
 // Returns an error if the section does not exist.
 func (p *ConfigParser) Options(section string) ([]string, error) {
@@ -317,7 +320,7 @@ func defaultGetFloat64(value string) (any, error) {
 }
 
 func defaultGetBool(value string) (any, error) {
-	booleanValue, present := boolMapping[value]
+	booleanValue, present := boolMapping[strings.ToLower(value)]
 	if !present {
 		return false, fmt.Errorf("not a boolean: %q", value)
 	}

methods_test.go

@@ -1,6 +1,7 @@
 package configparser_test
 
 import (
+	"errors"
 	"strings"
 
 	"github.com/bigkevmcd/go-configparser"
@@ -101,6 +102,22 @@ func (s *ConfigParserSuite) TestGet(c *gc.C) {
 	c.Assert(result, gc.Equals, "200")
 }
 
+func (s *ConfigParserSuite) TestGetConvError(c *gc.C) {
+	p, err := configparser.NewWithDefaults(
+		configparser.Dict{"key": "value"},
+		configparser.Converters(
+			configparser.Converter{
+				configparser.StringConv: func(s string) (any, error) {
+					return nil, errors.New("invalid string")
+				},
+			},
+		),
+	)
+	c.Assert(err, gc.IsNil)
+	_, err = p.Get("DEFAULT", "key")
+	c.Assert(err, gc.ErrorMatches, "invalid string")
+}
+
 // Get(section, option) should return the option value for the named section
 // regardless of case
 func (s *ConfigParserSuite) TestGetCamelCase(c *gc.C) {
@@ -279,14 +296,14 @@ func (s *ConfigParserSuite) TestGetBool(c *gc.C) {
 	newParser := configparser.New()
 	newParser.AddSection("testing")
 
-	for _, value := range []string{"1", "yes", "true", "on"} {
+	for _, value := range []string{"1", "yes", "true", "on", "True", "ON"} {
 		newParser.Set("testing", "value", value)
 		result, err := newParser.GetBool("testing", "value")
 		c.Assert(err, gc.IsNil)
 		c.Assert(result, gc.Equals, true)
 	}
 
-	for _, value := range []string{"0", "no", "false", "off"} {
+	for _, value := range []string{"0", "no", "false", "off", "False", "OFF"} {
 		newParser.Set("testing", "value", value)
 		result, err := newParser.GetBool("testing", "value")
 		c.Assert(err, gc.IsNil)