Call datasets.load_dataset. See what happens. (#538)

* Remove custom error handling.

* Fix wrong function call.

Author: stephenbach

promptsource/app.py

@@ -246,13 +246,7 @@ def get_infos(d_name):
         if len(configs) > 0:
             conf_option = st.sidebar.selectbox("Subset", configs, index=0, format_func=lambda a: a.name)
 
-        dataset, failed = get_dataset(dataset_key, str(conf_option.name) if conf_option else None)
-        if failed:
-            if dataset.manual_download_instructions is not None:
-                st.error(f"Dataset {dataset_key} requires manual download. Please skip for the moment.")
-            else:
-                st.error(f"Loading dataset {dataset_key} failed.\n{dataset}. Please skip for the moment.")
-
+        dataset = get_dataset(dataset_key, str(conf_option.name) if conf_option else None)
         splits = list(dataset.keys())
         index = 0
         if "train" in splits:

promptsource/utils.py

@@ -53,15 +53,11 @@ def get_dataset_builder(path, conf=None):
 def get_dataset(path, conf=None):
     "Get a dataset from name and conf."
     builder_instance = get_dataset_builder(path, conf)
-    fail = False
     if builder_instance.manual_download_instructions is None and builder_instance.info.size_in_bytes is not None:
         builder_instance.download_and_prepare()
-        dts = builder_instance.as_dataset()
-        dataset = dts
+        return builder_instance.as_dataset()
     else:
-        dataset = builder_instance
-        fail = True
-    return dataset, fail
+        return datasets.load_dataset(path, conf)
 
 
 def get_dataset_confs(path):

test/show_templates.py

@@ -18,7 +18,7 @@
 subset_name = path[3] if len(path) == 5 else ""
 template_collection = TemplateCollection()
 
-dataset, _ = get_dataset(dataset_name, subset_name)
+dataset = get_dataset(dataset_name, subset_name)
 splits = list(dataset.keys())
 
 dataset_templates = template_collection.get_dataset(dataset_name, subset_name)