TypeError: strMessage.trim is not a function, ws problem?

[WarlockD]

(node:59108) UnhandledPromiseRejectionWarning: TypeError: strMessage.trim is not a function at BidirectionalWebsocketRouter._routeMessage (H:\StationneerDev\DiscordBot\node_modules\jsonrpc-bidirectional\src\BidirectionalWebsocketRouter.js:167:18)
Took me a while to trace this down. WebSocket returns not a string but a Buffer Object you can check out the code for it here
https://github.com/websockets/ws/blob/master/lib/buffer-util.js

I did a quick hack of`

strMessage = `${strMessage}`;

just to get my crappy project done.

As a side note I hate HATE this bug. I run in to ".trim is not a function" all the time and would of expected ws to guarantee string text messages:P

[oxygen]

What library are you using on the other side?

It is not suposed to send binary encoded messages for json-rpc communication.

We could improve the code in this library by rethrowing a nicer error message or by silently dropping non-string WebSocket messages.

Also, what’s the ws version? If you’re using the latest, it might have a different way of doing things, like always returning a buffer for messages. We could update to support the newer ws API if that’s the case.