Is dendency to laravel-request-logger intended?

[mjess]

When installing laravel-route-statistics v4.0.0 it installs bilfeldt/laravel-request-logger (v3.4.0) along with it.

This seems to add the artisan command requestlog:prune to the artisan menu

However when running this php artisan requestlog:prune. I get:

PDOException::("SQLSTATE[42S02]: Base table or view not found: 1146 Table 'example_app.request_logs' doesn't exist")

Which makes sense, as I followed only the installation instruction of "laravel-route-statistics" and that one does not mention anything about running also the migrations of "laravel-request-logger".

So I wonder if the the "laravel-request-logger" is really needed? If so, should I also follow the manual of that one and publish and run the related migrations? Because so far the laravel-route-statistics seems to run fine w/o doing so.

[bilfeldt]

You do not need to follow the installation instructions from that package. If you do not follow them, not all features from that package are available, however - like this command that you are mentioning.

The package is used because it uses logic from that package to do the logging. This could perhaps be refactored to decouple the two packages although:

laravel-route-statistics/src/LaravelRouteStatisticsServiceProvider.php

Lines 95 to 102 in e1dabb8

	private function bootLogger()
	{
	RequestLoggerFacade::extend('routestat', function ($app) {
	$model = config('route-statistics.model');
	return new $model();
	});
	}

I am open to considering such a PR.

[mjess]

Thanks - The dependency itself is fine for me, my only concern is that I now have an artisan command in the menu which produces an exception which is not that nice - however as there are not too many accessing the appliaction at console level I can live with that.