Merge pull request #398 from binance/derivatives_trading_options_v1.1.1

Release derivatives trading option client version 1.1.1

Author: alplabin

.github/workflows/release.yaml

@@ -24,7 +24,11 @@ jobs:
           echo "::set-output name=clients::$ALL_CLIENTS"
 
   release:
+    needs: detect-clients
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        client: ${{ fromJson(needs.detect-clients.outputs.clients) }}
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
@@ -38,7 +42,7 @@ jobs:
             cd clients/${{ matrix.client }}
           fi
 
-          old_version=$(git show HEAD:pyproject.toml | grep '^version' | head -1 | sed -E 's/version = "(.*)"/\1/')
+          old_version=$(git show HEAD^:clients/${{ matrix.client }}/pyproject.toml | grep '^version' | head -1 | sed -E 's/version = "(.*)"/\1/')
           new_version=$(grep '^version' pyproject.toml | head -1 | sed -E 's/version = "(.*)"/\1/')
           
           if [ "$old_version" = "$new_version" ]; then
@@ -72,4 +76,4 @@ jobs:
 
       - name: Publish to pypi
         working-directory: ${{ steps.path.outputs.dir }}
-        run: poetry publish --build
+        run: poetry publish --build --no-interaction

clients/derivatives_trading_options/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## 1.1.1 - 2025-08-06
+
+### Changed (1)
+
+#### REST API
+
+- Moved `option_margin_account_information` unit tests from `test_market_maker_endpoints_api` folder to `test_account_api`
+
 ## 1.1.0 - 2025-08-06
 
 ### Changed (4)

…nts/option_margin_account_information.py …unt/option_margin_account_information.pyclients/derivatives_trading_options/examples/rest_api/MarketMakerEndpoints/option_margin_account_information.py renamed to clients/derivatives_trading_options/examples/rest_api/Account/option_margin_account_information.py clients/derivatives_trading_options/examples/rest_api/MarketMakerEndpoints/option_margin_account_information.py renamed to clients/derivatives_trading_options/examples/rest_api/Account/option_margin_account_information.py

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "binance-sdk-derivatives-trading-options"
-version = "1.1.0"
+version = "1.1.1"
 description = "Official Binance Derivatives Trading Options SDK - A lightweight library that provides a convenient interface to Binance's DerivativesTradingOptions REST API and WebSocket Streams."
 authors = ["Binance"]
 license = "MIT"

clients/derivatives_trading_options/pyproject.toml

@@ -32,6 +32,9 @@
 from binance_sdk_derivatives_trading_options.rest_api.models import (
     OptionAccountInformationResponse,
 )
+from binance_sdk_derivatives_trading_options.rest_api.models import (
+    OptionMarginAccountInformationResponse,
+)
 
 
 class TestAccountApi:
@@ -655,3 +658,144 @@ def test_option_account_information_server_error(self):
 
         with pytest.raises(Exception, match="ResponseError"):
             self.client.option_account_information()
+
+    @patch("binance_common.utils.get_signature")
+    def test_option_margin_account_information_success(self, mock_get_signature):
+        """Test option_margin_account_information() successfully with required parameters only."""
+
+        expected_response = {
+            "asset": [
+                {
+                    "asset": "USDT",
+                    "marginBalance": "10099.448",
+                    "equity": "10094.44662",
+                    "available": "8725.92524",
+                    "initialMargin": "1084.52138",
+                    "maintMargin": "151.00138",
+                    "unrealizedPNL": "-5.00138",
+                    "adjustedEquity": "34.13282285",
+                }
+            ],
+            "greek": [
+                {
+                    "underlying": "BTCUSDT",
+                    "delta": "-0.05",
+                    "gamma": "-0.002",
+                    "theta": "-0.05",
+                    "vega": "-0.002",
+                }
+            ],
+            "time": 1592449455993,
+        }
+        mock_get_signature.return_value = "mocked_signature"
+        self.set_mock_response(expected_response)
+
+        response = self.client.option_margin_account_information()
+
+        actual_call_args = self.mock_session.request.call_args
+        request_kwargs = actual_call_args.kwargs
+
+        self.mock_session.request.assert_called_once()
+        mock_get_signature.assert_called_once()
+
+        assert "url" in request_kwargs
+        assert "signature" in parse_qs(request_kwargs["params"])
+        assert "/eapi/v1/marginAccount" in request_kwargs["url"]
+        assert request_kwargs["method"] == "GET"
+
+        assert response is not None
+        is_list = isinstance(expected_response, list)
+        is_flat_list = (
+            is_list and not isinstance(expected_response[0], list) if is_list else False
+        )
+        is_oneof = is_one_of_model(OptionMarginAccountInformationResponse)
+
+        if is_list and not is_flat_list:
+            expected = expected_response
+        elif is_oneof or is_list:
+            expected = OptionMarginAccountInformationResponse.from_dict(
+                expected_response
+            )
+        else:
+            expected = OptionMarginAccountInformationResponse.model_validate_json(
+                json.dumps(expected_response)
+            )
+
+        assert response.data() == expected
+
+    @patch("binance_common.utils.get_signature")
+    def test_option_margin_account_information_success_with_optional_params(
+        self, mock_get_signature
+    ):
+        """Test option_margin_account_information() successfully with optional parameters."""
+
+        params = {"recv_window": 5000}
+
+        expected_response = {
+            "asset": [
+                {
+                    "asset": "USDT",
+                    "marginBalance": "10099.448",
+                    "equity": "10094.44662",
+                    "available": "8725.92524",
+                    "initialMargin": "1084.52138",
+                    "maintMargin": "151.00138",
+                    "unrealizedPNL": "-5.00138",
+                    "adjustedEquity": "34.13282285",
+                }
+            ],
+            "greek": [
+                {
+                    "underlying": "BTCUSDT",
+                    "delta": "-0.05",
+                    "gamma": "-0.002",
+                    "theta": "-0.05",
+                    "vega": "-0.002",
+                }
+            ],
+            "time": 1592449455993,
+        }
+        mock_get_signature.return_value = "mocked_signature"
+        self.set_mock_response(expected_response)
+
+        response = self.client.option_margin_account_information(**params)
+
+        actual_call_args = self.mock_session.request.call_args
+        request_kwargs = actual_call_args.kwargs
+
+        assert "url" in request_kwargs
+        assert "signature" in parse_qs(request_kwargs["params"])
+        assert "/eapi/v1/marginAccount" in request_kwargs["url"]
+        assert request_kwargs["method"] == "GET"
+
+        self.mock_session.request.assert_called_once()
+        assert response is not None
+        is_list = isinstance(expected_response, list)
+        is_flat_list = (
+            is_list and not isinstance(expected_response[0], list) if is_list else False
+        )
+        is_oneof = is_one_of_model(OptionMarginAccountInformationResponse)
+
+        if is_list and not is_flat_list:
+            expected = expected_response
+        elif is_oneof or is_list:
+            expected = OptionMarginAccountInformationResponse.from_dict(
+                expected_response
+            )
+        else:
+            expected = OptionMarginAccountInformationResponse.model_validate_json(
+                json.dumps(expected_response)
+            )
+
+        assert response.data() == expected
+
+    def test_option_margin_account_information_server_error(self):
+        """Test that option_margin_account_information() raises an error when the server returns an error."""
+
+        mock_error = Exception("ResponseError")
+        self.client.option_margin_account_information = MagicMock(
+            side_effect=mock_error
+        )
+
+        with pytest.raises(Exception, match="ResponseError"):
+            self.client.option_margin_account_information()

clients/derivatives_trading_options/tests/unit/rest_api/test_account_api.py

@@ -163,6 +163,7 @@ def test_exchange_information_success(self):
                     "unit": 1,
                     "makerFeeRate": "0.0002",
                     "takerFeeRate": "0.0002",
+                    "liquidationFeeRate": "0.0019000",
                     "minQty": "0.01",
                     "maxQty": "100",
                     "initialMargin": "0.15",

clients/derivatives_trading_options/tests/unit/rest_api/test_market_data_api.py

@@ -29,9 +29,6 @@
 from binance_sdk_derivatives_trading_options.rest_api.models import (
     GetMarketMakerProtectionConfigResponse,
 )
-from binance_sdk_derivatives_trading_options.rest_api.models import (
-    OptionMarginAccountInformationResponse,
-)
 from binance_sdk_derivatives_trading_options.rest_api.models import (
     ResetMarketMakerProtectionConfigResponse,
 )
@@ -382,147 +379,6 @@ def test_get_market_maker_protection_config_server_error(self):
         with pytest.raises(Exception, match="ResponseError"):
             self.client.get_market_maker_protection_config()
 
-    @patch("binance_common.utils.get_signature")
-    def test_option_margin_account_information_success(self, mock_get_signature):
-        """Test option_margin_account_information() successfully with required parameters only."""
-
-        expected_response = {
-            "asset": [
-                {
-                    "asset": "USDT",
-                    "marginBalance": "10099.448",
-                    "equity": "10094.44662",
-                    "available": "8725.92524",
-                    "initialMargin": "1084.52138",
-                    "maintMargin": "151.00138",
-                    "unrealizedPNL": "-5.00138",
-                    "lpProfit": "-5.00138",
-                }
-            ],
-            "greek": [
-                {
-                    "underlying": "BTCUSDT",
-                    "delta": "-0.05",
-                    "gamma": "-0.002",
-                    "theta": "-0.05",
-                    "vega": "-0.002",
-                }
-            ],
-            "time": 1592449455993,
-        }
-        mock_get_signature.return_value = "mocked_signature"
-        self.set_mock_response(expected_response)
-
-        response = self.client.option_margin_account_information()
-
-        actual_call_args = self.mock_session.request.call_args
-        request_kwargs = actual_call_args.kwargs
-
-        self.mock_session.request.assert_called_once()
-        mock_get_signature.assert_called_once()
-
-        assert "url" in request_kwargs
-        assert "signature" in parse_qs(request_kwargs["params"])
-        assert "/eapi/v1/marginAccount" in request_kwargs["url"]
-        assert request_kwargs["method"] == "GET"
-
-        assert response is not None
-        is_list = isinstance(expected_response, list)
-        is_flat_list = (
-            is_list and not isinstance(expected_response[0], list) if is_list else False
-        )
-        is_oneof = is_one_of_model(OptionMarginAccountInformationResponse)
-
-        if is_list and not is_flat_list:
-            expected = expected_response
-        elif is_oneof or is_list:
-            expected = OptionMarginAccountInformationResponse.from_dict(
-                expected_response
-            )
-        else:
-            expected = OptionMarginAccountInformationResponse.model_validate_json(
-                json.dumps(expected_response)
-            )
-
-        assert response.data() == expected
-
-    @patch("binance_common.utils.get_signature")
-    def test_option_margin_account_information_success_with_optional_params(
-        self, mock_get_signature
-    ):
-        """Test option_margin_account_information() successfully with optional parameters."""
-
-        params = {"recv_window": 5000}
-
-        expected_response = {
-            "asset": [
-                {
-                    "asset": "USDT",
-                    "marginBalance": "10099.448",
-                    "equity": "10094.44662",
-                    "available": "8725.92524",
-                    "initialMargin": "1084.52138",
-                    "maintMargin": "151.00138",
-                    "unrealizedPNL": "-5.00138",
-                    "lpProfit": "-5.00138",
-                }
-            ],
-            "greek": [
-                {
-                    "underlying": "BTCUSDT",
-                    "delta": "-0.05",
-                    "gamma": "-0.002",
-                    "theta": "-0.05",
-                    "vega": "-0.002",
-                }
-            ],
-            "time": 1592449455993,
-        }
-        mock_get_signature.return_value = "mocked_signature"
-        self.set_mock_response(expected_response)
-
-        response = self.client.option_margin_account_information(**params)
-
-        actual_call_args = self.mock_session.request.call_args
-        request_kwargs = actual_call_args.kwargs
-
-        assert "url" in request_kwargs
-        assert "signature" in parse_qs(request_kwargs["params"])
-        assert "/eapi/v1/marginAccount" in request_kwargs["url"]
-        assert request_kwargs["method"] == "GET"
-
-        self.mock_session.request.assert_called_once()
-        assert response is not None
-        is_list = isinstance(expected_response, list)
-        is_flat_list = (
-            is_list and not isinstance(expected_response[0], list) if is_list else False
-        )
-        is_oneof = is_one_of_model(OptionMarginAccountInformationResponse)
-
-        if is_list and not is_flat_list:
-            expected = expected_response
-        elif is_oneof or is_list:
-            expected = OptionMarginAccountInformationResponse.from_dict(
-                expected_response
-            )
-        else:
-            expected = OptionMarginAccountInformationResponse.model_validate_json(
-                json.dumps(expected_response)
-            )
-
-        assert response.data() == expected
-
-    def test_option_margin_account_information_server_error(self):
-        """Test that option_margin_account_information() raises an error when the server returns an error."""
-
-        mock_error = Exception("ResponseError")
-        self.client.option_margin_account_information = MagicMock(
-            side_effect=mock_error
-        )
-
-        with pytest.raises(Exception, match="ResponseError"):
-            self.client.option_margin_account_information()
-
     @patch("binance_common.utils.get_signature")
     def test_reset_market_maker_protection_config_success(self, mock_get_signature):
         """Test reset_market_maker_protection_config() successfully with required parameters only."""