Skip to content

ConfigurationWebSocketAPI millisecond params have default values in seconds #455

@EntomoSci

Description

@EntomoSci

binance_common.configuration.ConfigurationWebSocketAPI have default values for timeout and reconnect_delay parameters as 5 when its docstring says they are in milliseconds. It should be like timeout of binance_common.configuration.ConfigurationRestAPI. This creates unexpected behavior and confusion with requests when relying on the default values for that config. This mismatch between the docstring and the default values for the parameters found here could be present in other places as well; a potential problem indeed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions