tests: switch from phantom to puppeteer

Author: darwin

.travis.yml

@@ -10,3 +10,4 @@ cache:
 before_install:
   - yes y | sudo lein upgrade
   - curl -sSL https://raw.githubusercontent.com/cljs-oss/canary/master/scripts/install-canary.sh | bash
+  - cd test; npm install

project.clj

@@ -163,11 +163,11 @@
             "compare-dead-code-with-pseudo-names" ["shell" "scripts/compare-dead-code.sh" "+testing,+dce-pseudo-names"]
             "test-tests"                          ["do"
                                                    ["with-profile" "+testing" "cljsbuild" "once" "tests"]
-                                                   ["shell" "phantomjs" "test/resources/phantom.js" "test/resources/run-tests.html"]]
+                                                   ["shell" "node" "test/resources/puppeteer.js" "test/resources" "run-tests.html"]]
             "test-tests-with-config"              ["do"
                                                    ["shell" "scripts/compile-tests-with-config.sh"]
-                                                   ["shell" "phantomjs" "test/resources/phantom.js" "test/resources/run-tests-with-config.html"]]
+                                                   ["shell" "node" "test/resources/puppeteer.js" "test/resources" "run-tests-with-config.html"]]
             "test-advanced-warning"               ["do"
                                                    ["with-profile" "+testing" "cljsbuild" "once" "advanced-warning"]
-                                                   ["shell" "phantomjs" "test/resources/phantom.js" "test/resources/run-advanced-warning.html"]]
+                                                   ["shell" "node" "test/resources/puppeteer.js" "test/resources" "run-advanced-warning.html"]]
             "release"                             ["shell" "scripts/release.sh"]})

src/lib/devtools/munging.cljs

@@ -138,7 +138,8 @@
 (defn trivial-fn-source? [fn-source]
   {:pre [(string? fn-source)]}
   (or (some? (re-matches #"function\s*\(\s*\)\s*\{\s*\}\s*" fn-source))
-      (some? (re-matches #"function.*\(\)\s*\{\s*\[native code\]\s*\}\s*" fn-source))))
+      (some? (re-matches #"function.*\(\)\s*\{\s*\[native code\]\s*\}\s*" fn-source))
+      (some? (re-matches #"function anonymous\(\s*\)\s*\{\s*\}" fn-source))))
 
 (defn cljs-fn?
   "Given a Javascript function object returns true if the function looks like a ClojureScript function.

test/.gitignore

@@ -0,0 +1,2 @@
+node_modules
+yarn.lock

test/package.json

@@ -0,0 +1,12 @@
+{
+  "name": "cljs-devtools-tests",
+  "version": "1.0.0",
+  "license": "MIT",
+  "private": true,
+  "devDependencies": {
+    "puppeteer": "^2.1.0",
+    "http-server": "^0.12.1"
+  },
+  "dependencies": {
+  }
+}

test/resources/js/promise-polyfill.js

@@ -0,0 +1,36 @@
+const puppeteer = require('puppeteer');
+
+const path = process.argv[2];
+const page = process.argv[3];
+
+const httpServer = require('http-server');
+
+const host = '127.0.0.1';
+const port = 3000;
+
+const url = `http://${host}:${port}/${page}`;
+
+const serverOptions = {root: path};
+
+const server = httpServer.createServer(serverOptions);
+
+server.listen(port, host, function () {
+  console.log(`Server running at http://${host}:${port}/`);
+
+  (async () => {
+    const browser = await puppeteer.launch();
+    const page = await browser.newPage();
+    page.on('console', msg => console.log(msg.text()));
+    console.log("navigating to: ", url);
+    await page.goto(url);
+
+    const failures = await page.evaluate(() => {
+      return window["test-failures"];
+    });
+
+    await browser.close();
+
+    process.exit(failures ? 100 : 0);
+  })();
+
+});

test/resources/phantom.js

@@ -4,7 +4,6 @@
 This file could be changed to include HTML for the tests to use
 during their operation.
 <script src="js/diff_match_patch.js" type="text/javascript"></script>
-<script src="js/promise-polyfill.js" type="text/javascript"></script>
 <script>
   // poor man's console listener
   var lastWarning = null;

test/resources/puppeteer.js

@@ -4,7 +4,6 @@
 This file could be changed to include HTML for the tests to use
 during their operation.
 <script src="js/diff_match_patch.js" type="text/javascript"></script>
-<script src="js/promise-polyfill.js" type="text/javascript"></script>
 <script src=".compiled/tests/build.js" type="text/javascript"></script>
 <script>
     window.selectedTestSuite = "adhoc-tests";