fix: sort extensions in lexical order

binarycodes · binarycodes · commit 735c0b7342c6 · 2025-11-02T12:17:27.000+02:00
diff --git a/server/ssh-key-signer-server/src/main/java/io/binarycodes/homelab/sshkeysigner/keymanagement/SshCertManager.java b/server/ssh-key-signer-server/src/main/java/io/binarycodes/homelab/sshkeysigner/keymanagement/SshCertManager.java
@@ -66,7 +66,9 @@ private static List<CertificateExtension> buildCertificateExtensions(SshCertific
         }
 
         final var extensionsBuilder = new CertificateExtension.Builder();
-        knownExtensions.forEach(extension -> extensionsBuilder.knownExtension(new NamedCertificateExtension(extension, true)));
+        knownExtensions.stream()
+                .sorted()
+                .forEach(extension -> extensionsBuilder.knownExtension(new NamedCertificateExtension(extension, true)));
         return extensionsBuilder.build();
     }
 

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,9 @@ private static List<CertificateExtension> buildCertificateExtensions(SshCertific`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`final var extensionsBuilder = new CertificateExtension.Builder();`
`69`		`- knownExtensions.forEach(extension -> extensionsBuilder.knownExtension(new NamedCertificateExtension(extension, true)));`
	`69`	`+ knownExtensions.stream()`
	`70`	`+ .sorted()`
	`71`	`+ .forEach(extension -> extensionsBuilder.knownExtension(new NamedCertificateExtension(extension, true)));`
`70`	`72`	`return extensionsBuilder.build();`
`71`	`73`	`}`
`72`	`74`