Redis cache: improve test coverage

Author: binaryfire

tests/Cache/Redis/Concerns/MocksRedisConnections.php

@@ -168,17 +168,18 @@ protected function createStore(
      * This eliminates the boilerplate of manually setting up RedisCluster mocks,
      * connection mocks, pool mocks, and pool factory mocks for each cluster test.
      *
-     * Returns both the store and the cluster client mock so tests can set expectations:
+     * Returns the store, cluster client mock, and connection mock so tests can set expectations:
      * ```php
-     * [$store, $clusterClient] = $this->createClusterStore();
+     * [$store, $clusterClient, $connection] = $this->createClusterStore();
      * $clusterClient->shouldNotReceive('pipeline');
      * $clusterClient->shouldReceive('zadd')->once()->andReturn(1);
+     * $connection->shouldReceive('del')->once()->andReturn(1); // connection-level operations
      * ```
      *
      * @param string $prefix Cache key prefix
      * @param string $connectionName Redis connection name
      * @param string|null $tagMode Optional tag mode ('any' or 'all')
-     * @return array{0: RedisStore, 1: m\MockInterface} [store, clusterClient]
+     * @return array{0: RedisStore, 1: m\MockInterface, 2: m\MockInterface} [store, clusterClient, connection]
      */
     protected function createClusterStore(
         string $prefix = 'prefix:',
@@ -199,6 +200,6 @@ protected function createClusterStore(
             $store->setTagMode($tagMode);
         }
 
-        return [$store, $clusterClient];
+        return [$store, $clusterClient, $connection];
     }
 }

tests/Cache/Redis/Operations/AllTag/FlushTest.php

@@ -249,4 +249,153 @@ public function testFlushTagKeyFormat(): void
 
         $operation->execute(['_all:tag:my-special-tag:entries'], ['my-special-tag']);
     }
+
+    /**
+     * @test
+     */
+    public function testFlushInClusterModeUsesSequentialDel(): void
+    {
+        [$store, $clusterClient, $clusterConnection] = $this->createClusterStore();
+
+        // Mock GetEntries to return cache keys
+        $getEntries = m::mock(GetEntries::class);
+        $getEntries->shouldReceive('execute')
+            ->once()
+            ->with(['_all:tag:users:entries'])
+            ->andReturn(new LazyCollection(['key1', 'key2']));
+
+        // Cluster mode should NOT use pipeline
+        $clusterClient->shouldNotReceive('pipeline');
+
+        // Should delete cache entries directly (sequential DEL)
+        $clusterClient->shouldReceive('del')
+            ->once()
+            ->with('prefix:key1', 'prefix:key2')
+            ->andReturn(2);
+
+        // Should delete the tag sorted set
+        $clusterConnection->shouldReceive('del')
+            ->once()
+            ->with('prefix:_all:tag:users:entries')
+            ->andReturn(1);
+
+        $operation = new Flush($store->getContext(), $getEntries);
+        $operation->execute(['_all:tag:users:entries'], ['users']);
+    }
+
+    /**
+     * @test
+     */
+    public function testFlushInClusterModeChunksLargeSets(): void
+    {
+        [$store, $clusterClient, $clusterConnection] = $this->createClusterStore();
+
+        // Create more than CHUNK_SIZE (1000) entries
+        $entries = [];
+        for ($i = 1; $i <= 1500; $i++) {
+            $entries[] = "key{$i}";
+        }
+
+        // Mock GetEntries to return many cache keys
+        $getEntries = m::mock(GetEntries::class);
+        $getEntries->shouldReceive('execute')
+            ->once()
+            ->with(['_all:tag:users:entries'])
+            ->andReturn(new LazyCollection($entries));
+
+        // Cluster mode should NOT use pipeline
+        $clusterClient->shouldNotReceive('pipeline');
+
+        // First chunk: 1000 entries (sequential DEL)
+        $firstChunkArgs = [];
+        for ($i = 1; $i <= 1000; $i++) {
+            $firstChunkArgs[] = "prefix:key{$i}";
+        }
+        $clusterClient->shouldReceive('del')
+            ->once()
+            ->with(...$firstChunkArgs)
+            ->andReturn(1000);
+
+        // Second chunk: 500 entries (sequential DEL)
+        $secondChunkArgs = [];
+        for ($i = 1001; $i <= 1500; $i++) {
+            $secondChunkArgs[] = "prefix:key{$i}";
+        }
+        $clusterClient->shouldReceive('del')
+            ->once()
+            ->with(...$secondChunkArgs)
+            ->andReturn(500);
+
+        // Should delete the tag sorted set
+        $clusterConnection->shouldReceive('del')
+            ->once()
+            ->with('prefix:_all:tag:users:entries')
+            ->andReturn(1);
+
+        $operation = new Flush($store->getContext(), $getEntries);
+        $operation->execute(['_all:tag:users:entries'], ['users']);
+    }
+
+    /**
+     * @test
+     */
+    public function testFlushInClusterModeWithMultipleTags(): void
+    {
+        [$store, $clusterClient, $clusterConnection] = $this->createClusterStore();
+
+        // Mock GetEntries to return cache keys from multiple tags
+        $getEntries = m::mock(GetEntries::class);
+        $getEntries->shouldReceive('execute')
+            ->once()
+            ->with(['_all:tag:users:entries', '_all:tag:posts:entries'])
+            ->andReturn(new LazyCollection(['user_key1', 'user_key2', 'post_key1']));
+
+        // Cluster mode should NOT use pipeline
+        $clusterClient->shouldNotReceive('pipeline');
+
+        // Should delete all cache entries (sequential DEL)
+        $clusterClient->shouldReceive('del')
+            ->once()
+            ->with('prefix:user_key1', 'prefix:user_key2', 'prefix:post_key1')
+            ->andReturn(3);
+
+        // Should delete both tag sorted sets
+        $clusterConnection->shouldReceive('del')
+            ->once()
+            ->with('prefix:_all:tag:users:entries', 'prefix:_all:tag:posts:entries')
+            ->andReturn(2);
+
+        $operation = new Flush($store->getContext(), $getEntries);
+        $operation->execute(['_all:tag:users:entries', '_all:tag:posts:entries'], ['users', 'posts']);
+    }
+
+    /**
+     * @test
+     */
+    public function testFlushInClusterModeWithNoEntries(): void
+    {
+        [$store, $clusterClient, $clusterConnection] = $this->createClusterStore();
+
+        // Mock GetEntries to return empty collection
+        $getEntries = m::mock(GetEntries::class);
+        $getEntries->shouldReceive('execute')
+            ->once()
+            ->with(['_all:tag:users:entries'])
+            ->andReturn(new LazyCollection([]));
+
+        // Cluster mode should NOT use pipeline
+        $clusterClient->shouldNotReceive('pipeline');
+
+        // No cache entries to delete - del should NOT be called on cluster client
+        $clusterClient->shouldNotReceive('del');
+
+        // Should still delete the tag sorted set
+        $clusterConnection->shouldReceive('del')
+            ->once()
+            ->with('prefix:_all:tag:users:entries')
+            ->andReturn(1);
+
+        $operation = new Flush($store->getContext(), $getEntries);
+        $operation->execute(['_all:tag:users:entries'], ['users']);
+    }
 }