Clear stale errors before evalSha in evalWithShaCache

Add clearLastError() call before evalSha() to prevent stale errors from
previous commands causing incorrect error detection. Without this, a
successful evalSha returning nil could be mistaken for a NOSCRIPT error
if a previous command left an error in the buffer.

Add unit test verifying the call order.

Author: binaryfire

src/redis/src/RedisConnection.php

@@ -829,6 +829,10 @@ public function evalWithShaCache(string $script, array $keys = [], array $args =
         // combined_args = keys first, then other args
         $combinedArgs = [...$keys, ...$args];
 
+        // Clear any stale error from previous commands to ensure getLastError()
+        // reflects this call, not a previous one
+        $this->connection->clearLastError();
+
         // Try evalSha first - uses cached compiled script
         $result = $this->connection->evalSha($sha, $combinedArgs, $numKeys);
 

tests/Redis/RedisConnectionTest.php

@@ -832,6 +832,32 @@ public function testEvalWithShaCacheWorksWithMultipleKeysAndArgs(): void
         $this->assertEquals(['key1', 'key2', 'arg1', 'arg2'], $result);
     }
 
+    public function testEvalWithShaCacheClearsLastErrorBeforeEvalSha(): void
+    {
+        $connection = $this->mockRedisConnection();
+        $script = 'return "ok"';
+        $sha = sha1($script);
+
+        $redisConnection = $connection->getConnection();
+
+        // Verify clearLastError is called before evalSha using ordered expectations
+        $redisConnection->shouldReceive('clearLastError')
+            ->once()
+            ->globally()
+            ->ordered();
+
+        $redisConnection->shouldReceive('evalSha')
+            ->with($sha, [], 0)
+            ->once()
+            ->globally()
+            ->ordered()
+            ->andReturn('ok');
+
+        $result = $connection->evalWithShaCache($script);
+
+        $this->assertEquals('ok', $result);
+    }
+
     protected function mockRedisConnection(?ContainerInterface $container = null, ?PoolInterface $pool = null, array $options = [], bool $transform = false): RedisConnection
     {
         $connection = new RedisConnectionStub(