Improve error messages

Author: binaryfire

src/Concerns/ValidatesKvStore.php

@@ -4,6 +4,7 @@
 
 namespace App\Concerns;
 
+use App\Enums\HttpStatusEnum;
 use React\Http\Message\Response;
 
 trait ValidatesKvStore
@@ -17,14 +18,25 @@ trait ValidatesKvStore
     private function validateKeyOrError(string $key): ?Response
     {
         if (empty($key)) {
-            return Response::plaintext('Key is required')->withStatus(400);
+            return $this->createValidationErrorResponse('Key is required');
         }
 
         // Check for lowercase snake_case format
         if (!preg_match('/^[a-z0-9]+(_[a-z0-9]+)*$/', $key)) {
-            return Response::plaintext('Key must be in lowercase snake_case format')->withStatus(400);
+            return $this->createValidationErrorResponse('Key must be in lowercase snake_case format');
         }
 
         return null;
     }
+
+    /**
+     * Create a validation error response
+     */
+    private function createValidationErrorResponse(string $message): Response
+    {
+        $status = HttpStatusEnum::bad_request;
+
+        return Response::plaintext("Error {$status->value}: $message")
+            ->withStatus($status->value);
+    }    
 }

src/Controllers/KvStore/DeleteKeyController.php

@@ -5,6 +5,7 @@
 namespace App\Controllers\KvStore;
 
 use App\Concerns\ValidatesKvStore;
+use App\Enums\HttpStatusEnum;
 use App\Exceptions\KvStoreException;
 use App\Services\KvStoreService;
 use Psr\Http\Message\ServerRequestInterface;
@@ -32,12 +33,12 @@ public function __invoke(ServerRequestInterface $request)
 
         return $this->kvStore->delete($key)->then(
             function () {
-                return Response::plaintext('OK')->withStatus(200);
+                return Response::plaintext('')->withStatus(HttpStatusEnum::no_content->value);
             },
 
             function (KvStoreException $e) {
                 error_log("Error deleting key: " . $e->getMessage());
-                return Response::plaintext('Internal Server Error')->withStatus(500);
+                return Response::plaintext('')->withStatus(HttpStatusEnum::internal_server_error->value);
             }
         );
     }

src/Controllers/KvStore/GetKeyController.php

@@ -5,6 +5,7 @@
 namespace App\Controllers\KvStore;
 
 use App\Concerns\ValidatesKvStore;
+use App\Enums\HttpStatusEnum;
 use App\Exceptions\KvStoreException;
 use App\Services\KvStoreService;
 use Psr\Http\Message\ServerRequestInterface;
@@ -33,15 +34,15 @@ public function __invoke(ServerRequestInterface $request)
         return $this->kvStore->get($key)->then(
             function ($result) {
                 if (empty($result->rows)) {
-                    return Response::plaintext('')->withStatus(404);
+                    return Response::plaintext('')->withStatus(HttpStatusEnum::not_found->value);
                 }
 
                 return Response::plaintext($result->rows[0]['value']);
             },
 
             function (KvStoreException $e) {
                 error_log("Error getting key: " . $e->getMessage());
-                return Response::plaintext('Internal Server Error')->withStatus(500);
+                return Response::plaintext('')->withStatus(HttpStatusEnum::internal_server_error->value);
             }
         );
     }

src/Controllers/KvStore/ListKeysController.php

@@ -4,9 +4,9 @@
 
 namespace App\Controllers\KvStore;
 
+use App\Enums\HttpStatusEnum;
 use App\Exceptions\KvStoreException;
 use App\Services\KvStoreService;
-use Psr\Http\Message\ServerRequestInterface;
 use React\Http\Message\Response;
 
 class ListKeysController
@@ -35,8 +35,8 @@ function ($result) {
 
             function (KvStoreException $e) {
                 error_log("Error listing keys: " . $e->getMessage());
-                Response::plaintext('Internal Server Error')->withStatus(500);
-            }
+                Response::plaintext('')->withStatus(HttpStatusEnum::internal_server_error->value);
+                }
         );
     }
 }

src/Controllers/KvStore/SetKeyController.php

@@ -5,6 +5,7 @@
 namespace App\Controllers\KvStore;
 
 use App\Concerns\ValidatesKvStore;
+use App\Enums\HttpStatusEnum;
 use App\Exceptions\KvStoreException;
 use App\Services\KvStoreService;
 use Psr\Http\Message\ServerRequestInterface;
@@ -34,12 +35,12 @@ public function __invoke(ServerRequestInterface $request)
 
         return $this->kvStore->set($key, $value)->then(
             function () {
-                return Response::plaintext('OK')->withStatus(200);
+                return Response::plaintext('')->withStatus(HttpStatusEnum::no_content->value);
             },
 
             function (KvStoreException $e) {
                 error_log("Error setting key: " . $e->getMessage());
-                return Response::plaintext('Internal Server Error')->withStatus(500);
+                return Response::plaintext('')->withStatus(HttpStatusEnum::internal_server_error->value);
             }
         );
     }

src/Middleware/PlainTextErrorResponseMiddleware.php

@@ -27,7 +27,8 @@ private function handle(ResponseInterface $response): ResponseInterface
     {
         $statusCode = $response->getStatusCode();
 
-        if ($statusCode >= 400) {
+        // Status 400 is used for validation errors and should be excluded
+        if ($statusCode >= 401) {
             $statusEnum = HttpStatusEnum::tryFrom($statusCode);
 
             $description = $statusEnum ? $statusEnum->getDescription() : 'Error';