Do not use undefined dimensions on visuals

binarykitchen · binarykitchen · commit 032f324d7329 · 2025-12-19T12:18:13.000+13:00
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -80,7 +80,7 @@
     "@rsbuild/plugin-node-polyfill": "1.4.2",
     "@rsbuild/plugin-stylus": "1.2.0",
     "@rsdoctor/rspack-plugin": "1.3.16",
-    "@rslib/core": "0.18.4",
+    "@rslib/core": "0.18.5",
     "@storybook/addon-a11y": "10.1.10",
     "@storybook/addon-docs": "10.1.10",
     "@storybook/addon-links": "10.1.10",
diff --git a/src/wrappers/visuals.ts b/src/wrappers/visuals.ts
@@ -127,13 +127,13 @@ class Visuals extends Despot {
         heightDimension = this.getRecorderHeight(true);
       }
 
-      if (widthDimension) {
+      if (widthDimension?.value) {
         this.visualsElement.style.width = `${widthDimension.value}${widthDimension.unit}`;
       } else {
         this.visualsElement.style.removeProperty("width");
       }
 
-      if (heightDimension) {
+      if (heightDimension?.value) {
         this.visualsElement.style.height = `${heightDimension.value}${heightDimension.unit}`;
       } else {
         this.visualsElement.style.removeProperty("height");

Original file line number	Diff line number	Diff line change
`@@ -127,13 +127,13 @@ class Visuals extends Despot {`
`127`	`127`	`heightDimension = this.getRecorderHeight(true);`
`128`	`128`	`}`
`129`	`129`
`130`		`- if (widthDimension) {`
	`130`	`+ if (widthDimension?.value) {`
`131`	`131`	this.visualsElement.style.width = `${widthDimension.value}${widthDimension.unit}`;
`132`	`132`	`} else {`
`133`	`133`	`this.visualsElement.style.removeProperty("width");`
`134`	`134`	`}`
`135`	`135`
`136`		`- if (heightDimension) {`
	`136`	`+ if (heightDimension?.value) {`
`137`	`137`	this.visualsElement.style.height = `${heightDimension.value}${heightDimension.unit}`;
`138`	`138`	`} else {`
`139`	`139`	`this.visualsElement.style.removeProperty("height");`