Skip to content

Commit 890788c

Browse files
committed
change reportErrors to default and improve one error msg
1 parent 6313421 commit 890788c

File tree

4 files changed

+8
-11
lines changed

4 files changed

+8
-11
lines changed

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888
"@tsconfig/node22": "22.0.0",
8989
"@tsconfig/strictest": "2.0.5",
9090
"@types/defined": "1.0.2",
91-
"@types/node": "22.9.1",
91+
"@types/node": "22.9.3",
9292
"@types/superagent": "8.1.9",
9393
"@types/ua-parser-js": "0.7.39",
9494
"@vitest/eslint-plugin": "1.1.10",

src/options.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -161,11 +161,8 @@ const options: VideomailClientOptions = {
161161
// true = all form inputs get disabled and disappear when browser can't record
162162
adjustFormOnBrowserError: true,
163163

164-
/*
165-
* when true, any errors will be sent to the videomail server for analysis
166-
* ps: can be a function too returning a boolean
167-
*/
168-
reportErrors: false,
164+
// when true, any errors will be sent to the videomail server for analysis
165+
reportErrors: true,
169166

170167
// just for testing purposes to simulate browser agent handling
171168
fakeUaString: undefined,

src/util/html/dimensions/calculateHeight.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ function calculateHeight(
1515

1616
if (width < 1) {
1717
throw createError({
18-
message: "Unable to calculate height when width is less than 1.",
18+
message: `Unable to calculate height when width is less than 1 (= ${width}) and responsive mode is set to ${responsive}`,
1919
options,
2020
});
2121
} else if (responsive && element) {

0 commit comments

Comments
 (0)