[COMPBATT] Free device-related memory only if we failed

hpoussin · hpoussin · commit 05ae94092e6b · 2024-11-20T21:47:13.000+01:00
Otherwise, we just inserted in the BatteryList this device, and we will
probably crash later when accessing it.
diff --git a/drivers/bus/acpi/compbatt/comppnp.c b/drivers/bus/acpi/compbatt/comppnp.c
@@ -199,8 +199,11 @@ CompBattAddNewBattery(IN PUNICODE_STRING BatteryName,
                          Status);
             }
 
-            /* Free the battery data */
-            ExFreePool(BatteryData);
+            if (!NT_SUCCESS(Status))
+            {
+                /* Free the battery data */
+                ExFreePool(BatteryData);
+            }
         }
         else
         {

Original file line number	Diff line number	Diff line change
`@@ -199,8 +199,11 @@ CompBattAddNewBattery(IN PUNICODE_STRING BatteryName,`
`199`	`199`	`Status);`
`200`	`200`	`}`
`201`	`201`
`202`		`- /* Free the battery data */`
`203`		`- ExFreePool(BatteryData);`
	`202`	`+ if (!NT_SUCCESS(Status))`
	`203`	`+ {`
	`204`	`+ /* Free the battery data */`
	`205`	`+ ExFreePool(BatteryData);`
	`206`	`+ }`
`204`	`207`	`}`
`205`	`208`	`else`
`206`	`209`	`{`