[WKSSVC] Plug memory leaks in NetrWkstaUserGetInfo

tkreuzer · tkreuzer · commit 132d571fe2c5 · 2025-01-17T12:54:29.000+02:00
diff --git a/base/services/wkssvc/rpcserver.c b/base/services/wkssvc/rpcserver.c
@@ -762,6 +762,7 @@ NetrWkstaUserGetInfo(
             if (pUserInfo->UserInfo0.wkui0_username == NULL)
             {
                 ERR("\n");
+                midl_user_free(pUserInfo);
                 dwResult = ERROR_NOT_ENOUGH_MEMORY;
                 break;
             }
@@ -792,6 +793,7 @@ NetrWkstaUserGetInfo(
             if (pUserInfo->UserInfo1.wkui1_username == NULL)
             {
                 ERR("\n");
+                midl_user_free(pUserInfo);
                 dwResult = ERROR_NOT_ENOUGH_MEMORY;
                 break;
             }
@@ -808,6 +810,8 @@ NetrWkstaUserGetInfo(
             if (pUserInfo->UserInfo1.wkui1_logon_domain == NULL)
             {
                 ERR("\n");
+                midl_user_free(pUserInfo->UserInfo1.wkui1_username);
+                midl_user_free(pUserInfo);
                 dwResult = ERROR_NOT_ENOUGH_MEMORY;
                 break;
             }
@@ -826,6 +830,9 @@ NetrWkstaUserGetInfo(
             if (pUserInfo->UserInfo1.wkui1_logon_server == NULL)
             {
                 ERR("\n");
+                midl_user_free(pUserInfo->UserInfo1.wkui1_username);
+                midl_user_free(pUserInfo->UserInfo1.wkui1_logon_domain);
+                midl_user_free(pUserInfo);
                 dwResult = ERROR_NOT_ENOUGH_MEMORY;
                 break;
             }

Original file line number	Diff line number	Diff line change
`@@ -762,6 +762,7 @@ NetrWkstaUserGetInfo(`
`762`	`762`	`if (pUserInfo->UserInfo0.wkui0_username == NULL)`
`763`	`763`	`{`
`764`	`764`	`ERR("\n");`
	`765`	`+ midl_user_free(pUserInfo);`
`765`	`766`	`dwResult = ERROR_NOT_ENOUGH_MEMORY;`
`766`	`767`	`break;`
`767`	`768`	`}`
`@@ -792,6 +793,7 @@ NetrWkstaUserGetInfo(`
`792`	`793`	`if (pUserInfo->UserInfo1.wkui1_username == NULL)`
`793`	`794`	`{`
`794`	`795`	`ERR("\n");`
	`796`	`+ midl_user_free(pUserInfo);`
`795`	`797`	`dwResult = ERROR_NOT_ENOUGH_MEMORY;`
`796`	`798`	`break;`
`797`	`799`	`}`
`@@ -808,6 +810,8 @@ NetrWkstaUserGetInfo(`
`808`	`810`	`if (pUserInfo->UserInfo1.wkui1_logon_domain == NULL)`
`809`	`811`	`{`
`810`	`812`	`ERR("\n");`
	`813`	`+ midl_user_free(pUserInfo->UserInfo1.wkui1_username);`
	`814`	`+ midl_user_free(pUserInfo);`
`811`	`815`	`dwResult = ERROR_NOT_ENOUGH_MEMORY;`
`812`	`816`	`break;`
`813`	`817`	`}`
`@@ -826,6 +830,9 @@ NetrWkstaUserGetInfo(`
`826`	`830`	`if (pUserInfo->UserInfo1.wkui1_logon_server == NULL)`
`827`	`831`	`{`
`828`	`832`	`ERR("\n");`
	`833`	`+ midl_user_free(pUserInfo->UserInfo1.wkui1_username);`
	`834`	`+ midl_user_free(pUserInfo->UserInfo1.wkui1_logon_domain);`
	`835`	`+ midl_user_free(pUserInfo);`
`829`	`836`	`dwResult = ERROR_NOT_ENOUGH_MEMORY;`
`830`	`837`	`break;`
`831`	`838`	`}`