[PCIX] Fix a few easy bugs (reactos#8443)

* [PCIX] Fix the weird text corruption in PciGetDescriptionMessage

* [PCIX] Return the buffer to the caller PciQueryBusInformation


Co-authored-by: Stanislav Motylkov <[email protected]>

Author: DarkFire01

drivers/bus/pcix/pci.h

@@ -1164,7 +1164,7 @@ NTSTATUS
 NTAPI
 PciQueryBusInformation(
     IN PPCI_PDO_EXTENSION PdoExtension,
-    IN PPNP_BUS_INFORMATION* Buffer
+    OUT PPNP_BUS_INFORMATION* Buffer
 );
 
 NTSTATUS

drivers/bus/pcix/pci/id.c

@@ -48,20 +48,20 @@ PciGetDescriptionMessage(IN ULONG Identifier,
         /* Grab the text */
         Description = (PWCHAR)Entry->Text;
 
-        /* Validate valid message length, ending with a newline character */
-        ASSERT(TextLength > 1);
-        ASSERT(Description[TextLength / sizeof(WCHAR)] == L'\n');
+        /* Validate the message length, ending with a newline character */
+        ASSERT(TextLength > sizeof(WCHAR));
+        ASSERT(Description[(TextLength / sizeof(WCHAR)) - 1] == L'\n');
 
         /* Allocate the buffer to hold the message string */
         Buffer = ExAllocatePoolWithTag(PagedPool, TextLength, 'BicP');
         if (!Buffer) return NULL;
 
         /* Copy the message, minus the newline character, and terminate it */
-        RtlCopyMemory(Buffer, Entry->Text, TextLength - 1);
-        Buffer[TextLength / sizeof(WCHAR)] = UNICODE_NULL;
+        RtlCopyMemory(Buffer, Description, TextLength - sizeof(WCHAR));
+        Buffer[(TextLength / sizeof(WCHAR)) - 1] = UNICODE_NULL;
 
         /* Return the length to the caller, minus the terminating NULL */
-        if (Length) *Length = TextLength - 1;
+        if (Length) *Length = TextLength - sizeof(WCHAR);
     }
     else
     {

drivers/bus/pcix/utils.c

@@ -1314,12 +1314,10 @@ PciDecodeEnable(IN PPCI_PDO_EXTENSION PdoExtension,
 NTSTATUS
 NTAPI
 PciQueryBusInformation(IN PPCI_PDO_EXTENSION PdoExtension,
-                       IN PPNP_BUS_INFORMATION* Buffer)
+                       OUT PPNP_BUS_INFORMATION* Buffer)
 {
     PPNP_BUS_INFORMATION BusInfo;
 
-    UNREFERENCED_PARAMETER(Buffer);
-
     /* Allocate a structure for the bus information */
     BusInfo = ExAllocatePoolWithTag(PagedPool,
                                     sizeof(PNP_BUS_INFORMATION),
@@ -1330,6 +1328,9 @@ PciQueryBusInformation(IN PPCI_PDO_EXTENSION PdoExtension,
     BusInfo->BusTypeGuid = GUID_BUS_TYPE_PCI;
     BusInfo->LegacyBusType = PCIBus;
     BusInfo->BusNumber = PdoExtension->ParentFdoExtension->BaseBus;
+
+    *Buffer = BusInfo;
+
     return STATUS_SUCCESS;
 }