[KMTESTS] Kmtest fixes (reactos#8308)

- [KMTEST:IOFILESYSTEM] Add support for NTFS
- [KMTEST:IODEVICEOBJECT] Work around a Windows 7 bug, account for struct size changes on x64, accept Vista+ behavior
- [KMTEST:EXPOOLS] Accept pool being promoted to NonPaged on Vista+, accept 2GB allocation on x64, guard an undocumented behavior
- [KMTEST:CMSECURITY] Add tests for Vista-Win8.1

Author: maramadany

modules/rostests/kmtests/ntos_cm/CmSecurity.c

@@ -12,7 +12,7 @@
 
 #define TAG_POOLTEST 'tstP'
 
-#define BASE_POOL_TYPE_MASK 1
+#define BASE_POOL_TYPE_MASK 3
 #define QUOTA_POOL_MASK 8
 
 static
@@ -141,7 +141,6 @@ VOID
 TestPoolQuota(VOID)
 {
     PEPROCESS Process = PsGetCurrentProcess();
-    PEPROCESS StoredProcess;
     PVOID Memory;
     LONG InitialRefCount;
     LONG RefCount;
@@ -163,16 +162,23 @@ TestPoolQuota(VOID)
         RefCount = GetRefCount(Process);
         ok_eq_long(RefCount, InitialRefCount + 1);
 
-        /* A pointer to the process is found right before the next pool header */
-        StoredProcess = ((PVOID *)((ULONG_PTR)Memory + 2 * sizeof(LIST_ENTRY)))[-1];
-        ok_eq_pointer(StoredProcess, Process);
+#ifdef _M_IX86
+        if (GetNTVersion() <= _WIN32_WINNT_WIN7)
+        {
+            /* For x86 NT 6.2 and older: a pointer to the process is found right before the next pool header */
+            PEPROCESS StoredProcess = ((PVOID *)((ULONG_PTR)Memory + 2 * sizeof(LIST_ENTRY)))[-1];
+            ok_eq_pointer(StoredProcess, Process);
+        }
+#endif
 
         /* Pool type should have QUOTA_POOL_MASK set */
         PoolType = KmtGetPoolType(Memory);
         ok(PoolType != 0, "PoolType is 0\n");
         PoolType--;
         ok(PoolType & QUOTA_POOL_MASK, "PoolType = %x\n", PoolType);
-        ok((PoolType & BASE_POOL_TYPE_MASK) == PagedPool, "PoolType = %x\n", PoolType);
+        ok((PoolType & BASE_POOL_TYPE_MASK) == PagedPool ||                // Win2k3
+           (PoolType & BASE_POOL_TYPE_MASK) == NonPagedPoolMustSucceed,    // Vista+ promotes the memory allocation
+           "PoolType = %x\n", PoolType);
 
         ExFreePoolWithTag(Memory, 'tQmK');
         RefCount = GetRefCount(Process);
@@ -196,6 +202,16 @@ TestPoolQuota(VOID)
         ok_eq_long(RefCount, InitialRefCount);
     }
 
+#ifdef _WIN64
+    KmtStartSeh()
+        Memory = ExAllocatePoolWithQuotaTag(PagedPool,
+                                            0x7FFFFFFF,
+                                            'tQmK');
+        ok(Memory != NULL, "Failed to get 2GB block: %p\n", Memory);
+        if (Memory)
+            ExFreePoolWithTag(Memory, 'tQmK');
+    KmtEndSeh(STATUS_SUCCESS);
+#else
     /* Function raises by default */
     KmtStartSeh()
         Memory = ExAllocatePoolWithQuotaTag(PagedPool,
@@ -214,6 +230,7 @@ TestPoolQuota(VOID)
         if (Memory)
             ExFreePoolWithTag(Memory, 'tQmK');
     KmtEndSeh(STATUS_SUCCESS);
+#endif // _WIN64
 }
 
 static

modules/rostests/kmtests/ntos_ex/ExPools.c

@@ -181,9 +181,10 @@ TestDriverObject(
         ok_eq_pointer(DriverObject->DriverExtension->DriverObject, DriverObject);
         ok_eq_pointer(DriverObject->DriverExtension->AddDevice, NULL);
         ok_eq_ulong(DriverObject->DriverExtension->Count, 0UL);
+        /* Windows 7 doesn't capitalize "Services" like all other versions before and after it. */
         Equal = RtlEqualUnicodeString(RegistryPath,
                                       &RegPath,
-                                      FALSE);
+                                      (GetNTVersion() == _WIN32_WINNT_WIN7) ? TRUE : FALSE);
         ok(Equal, "RegistryPath is '%wZ'\n", RegistryPath);
         ok((ULONG_PTR)RegistryPath % PAGE_SIZE == 0, "RegistryPath %p not page-aligned\n", RegistryPath);
         ok_eq_pointer(RegistryPath->Buffer, (PWCHAR)(RegistryPath + 1));
@@ -193,7 +194,8 @@ TestDriverObject(
                                       FALSE);
         ok(Equal, "ServiceKeyName is '%wZ'\n", &DriverObject->DriverExtension->ServiceKeyName);
         ok_eq_tag(KmtGetPoolTag(DriverObject->DriverExtension->ServiceKeyName.Buffer), '  oI');
-        ok_eq_uint((KmtGetPoolType(DriverObject->DriverExtension->ServiceKeyName.Buffer) - 1) & BASE_POOL_TYPE_MASK, NonPagedPool);
+        if (GetNTVersion() <= _WIN32_WINNT_WS03) // Not guaranteed on Vista+
+            ok_eq_uint((KmtGetPoolType(DriverObject->DriverExtension->ServiceKeyName.Buffer) - 1) & BASE_POOL_TYPE_MASK, NonPagedPool);
         ok_eq_uint(DriverObject->DriverExtension->ServiceKeyName.MaximumLength, DriverObject->DriverExtension->ServiceKeyName.Length + sizeof(UNICODE_NULL));
         ok_eq_uint(DriverObject->DriverExtension->ServiceKeyName.Buffer[DriverObject->DriverExtension->ServiceKeyName.Length / sizeof(WCHAR)], UNICODE_NULL);
         Equal = RtlEqualUnicodeString(&DriverObject->DriverName,
@@ -348,7 +350,11 @@ TestDeviceCreated(
 
     /* Check the device object members */
     ok(DeviceObject->Type == 3, "Expected Type = 3, got %x\n", DeviceObject->Type);
-    ok(DeviceObject->Size == 0xb8, "Expected Size = 0xb8, got %x\n", DeviceObject->Size);
+#ifdef _M_IX86
+    ok(DeviceObject->Size == 0xb8, "Expected Size = 0xb8, got 0x%x\n", DeviceObject->Size);
+#else
+    ok(DeviceObject->Size == 0x150, "Expected Size = 0x150, got 0x%x\n", DeviceObject->Size);
+#endif
     ok(DeviceObject->ReferenceCount == 0, "Expected ReferenceCount = 0, got %lu\n",
         DeviceObject->ReferenceCount);
     ok(DeviceObject->DriverObject == ThisDriverObject,
@@ -368,17 +374,19 @@ TestDeviceCreated(
             "Expected Flags DO_DEVICE_HAS_NAME | DO_DEVICE_INITIALIZING, got %lu\n", DeviceObject->Flags);
     }
     ok(DeviceObject->DeviceType == FILE_DEVICE_UNKNOWN,
-        "Expected DeviceType to match creation parameter FILE_DEVICE_UNKNWOWN, got %lu\n",
+       "Expected DeviceType to match creation parameter FILE_DEVICE_UNKNWOWN, got %lu\n",
         DeviceObject->DeviceType);
     ok(DeviceObject->ActiveThreadCount == 0, "Expected ActiveThreadCount = 0, got %lu\n", DeviceObject->ActiveThreadCount);
 
     /* Check the extended extension */
     extdev = (PEXTENDED_DEVOBJ_EXTENSION)DeviceObject->DeviceObjectExtension;
-    ok(extdev->ExtensionFlags == 0, "Expected Extended ExtensionFlags to be 0, got %lu\n", extdev->ExtensionFlags);
-    ok (extdev->Type == 13, "Expected Type of 13, got %d\n", extdev->Type);
-    ok (extdev->Size == 0, "Expected Size of 0, got %d\n", extdev->Size);
-    ok (extdev->DeviceObject == DeviceObject, "Expected DeviceOject to match newly created device %p, got %p\n",
-        DeviceObject, extdev->DeviceObject);
+    ok(extdev->ExtensionFlags == DOE_DEFAULT_SD_PRESENT || // Vista+
+       extdev->ExtensionFlags == 0,                        // WS03
+       "Expected Extended ExtensionFlags to be DOE_DEFAULT_SD_PRESENT or 0, got %lu\n", extdev->ExtensionFlags);
+    ok(extdev->Type == 13, "Expected Type of 13, got %d\n", extdev->Type);
+    ok(extdev->Size == 0, "Expected Size of 0, got %d\n", extdev->Size);
+    ok(extdev->DeviceObject == DeviceObject, "Expected DeviceOject to match newly created device %p, got %p\n",
+       DeviceObject, extdev->DeviceObject);
     ok(extdev->AttachedTo == NULL, "Expected AttachTo to be NULL, got %p\n", extdev->AttachedTo);
     ok(extdev->StartIoCount == 0, "Expected StartIoCount = 0, got %lu\n", extdev->StartIoCount);
     ok(extdev->StartIoKey == 0, "Expected StartIoKey = 0, got %lu\n", extdev->StartIoKey);
@@ -396,7 +404,11 @@ TestDeviceDeletion(
 
     /* Check the device object members */
     ok(DeviceObject->Type == 3, "Expected Type = 3, got %d\n", DeviceObject->Type);
-    ok(DeviceObject->Size == 0xb8, "Expected Size = 0xb8, got %d\n", DeviceObject->Size);
+#ifdef _M_IX86
+    ok(DeviceObject->Size == 0xb8, "Expected Size = 0xb8, got 0x%x\n", DeviceObject->Size);
+#else
+    ok(DeviceObject->Size == 0x150, "Expected Size = 0x150, got 0x%x\n", DeviceObject->Size);
+#endif
     ok(DeviceObject->ReferenceCount == 0, "Expected ReferenceCount = 0, got %lu\n",
         DeviceObject->ReferenceCount);
     if (!Lower)
@@ -426,9 +438,9 @@ TestDeviceDeletion(
 
     /* Check the extended extension */
     extdev = (PEXTENDED_DEVOBJ_EXTENSION)DeviceObject->DeviceObjectExtension;
-    /* FIXME: Windows has the MSB set under some conditions, need to find out what this means */
-    ok((extdev->ExtensionFlags & 0x7fffffff) == DOE_UNLOAD_PENDING,
-        "Expected Extended ExtensionFlags to be DOE_UNLOAD_PENDING, got 0x%lx\n", extdev->ExtensionFlags);
+    ok((extdev->ExtensionFlags == (DOE_DEFAULT_SD_PRESENT | DOE_UNLOAD_PENDING) ||  // Vista+
+        extdev->ExtensionFlags & 0x7fffffff) == DOE_UNLOAD_PENDING,                 // WS03 FIXME: Windows has the MSB set under some conditions, need to find out what this means
+        "Unexpected Extended ExtensionFlags (0x%lx)\n", extdev->ExtensionFlags);
     ok (extdev->Type == 13, "Expected Type of 13, got %d\n", extdev->Type);
     ok (extdev->Size == 0, "Expected Size of 0, got %d\n", extdev->Size);
     ok (extdev->DeviceObject == DeviceObject, "Expected DeviceOject to match newly created device %p, got %p\n",