Skip to content

Commit 2f23e70

Browse files
authored
Revert "[NTUSER] Enable SM_CXICON etc. settings from registry (reactos#7679)" (reactos#7682)
This reverts commit 3b3741c of reactos#7679 . It seems like the shell icon size is not the system icon size. The wide string L"Shell Small Icon Size" is detected in shell32.dll and themeui.dll. No L"Shell Small Icon Size" in win32k.sys found. JIRA issue: CORE-12905
1 parent 3b3741c commit 2f23e70

File tree

3 files changed

+4
-18
lines changed

3 files changed

+4
-18
lines changed

win32ss/user/ntuser/metric.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
* FILE: win32ss/user/ntuser/metric.c
66
* PROGRAMER: Casper S. Hornstrup ([email protected])
77
* Timo Kreuzer ([email protected])
8-
* Katayama Hirofumi MZ ([email protected])
98
*/
109

1110
#include <win32k.h>
@@ -131,10 +130,10 @@ InitMetrics(VOID)
131130
piSysMet[SM_CXHTHUMB] = gspv.ncm.iScrollHeight; // 16;
132131
piSysMet[SM_CYVSCROLL] = gspv.ncm.iScrollHeight; // 16
133132
piSysMet[SM_CXHSCROLL] = gspv.ncm.iScrollHeight; // 16;
134-
piSysMet[SM_CXICON] = gspv.nIconSize; // 32
135-
piSysMet[SM_CYICON] = gspv.nIconSize; // 32
136-
piSysMet[SM_CXSMICON] = gspv.nSmallIconSize; // 16
137-
piSysMet[SM_CYSMICON] = gspv.nSmallIconSize; // 16
133+
piSysMet[SM_CXICON] = 32;
134+
piSysMet[SM_CYICON] = 32;
135+
piSysMet[SM_CXSMICON] = 16;
136+
piSysMet[SM_CYSMICON] = 16;
138137
piSysMet[SM_CXICONSPACING] = gspv.im.iHorzSpacing; // 64;
139138
piSysMet[SM_CYICONSPACING] = gspv.im.iVertSpacing; // 64;
140139
piSysMet[SM_CXCURSOR] = 32;

win32ss/user/ntuser/sysparams.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
* PURPOSE: System parameters functions
55
* FILE: win32ss/user/ntuser/sysparams.c
66
* PROGRAMER: Timo Kreuzer ([email protected])
7-
* Katayama Hirofumi MZ ([email protected])
87
*/
98

109
// TODO:
@@ -206,11 +205,6 @@ SpiFixupValues(VOID)
206205
// gspv.tmMenuFont.tmExternalLeading);
207206
if (gspv.iDblClickTime == 0) gspv.iDblClickTime = 500;
208207

209-
if (gspv.nIconSize <= 0)
210-
gspv.nIconSize = 32;
211-
if (gspv.nSmallIconSize <= 0)
212-
gspv.nSmallIconSize = 16;
213-
214208
// FIXME: Hack!!!
215209
gspv.tmMenuFont.tmHeight = 11;
216210
gspv.tmMenuFont.tmExternalLeading = 2;
@@ -302,10 +296,6 @@ SpiUpdatePerUserSystemParameters(VOID)
302296
gspv.im.iTitleWrap = SpiLoadMetric(VAL_ITWRAP, 1);
303297
SpiLoadFont(&gspv.im.lfFont, L"IconFont", &lf1);
304298

305-
/* Load icon size */
306-
gspv.nIconSize = SpiLoadInt(KEY_METRIC, L"Shell Icon Size", 32);
307-
gspv.nSmallIconSize = SpiLoadInt(KEY_METRIC, L"Shell Small Icon Size", 16);
308-
309299
/* Load desktop settings */
310300
gspv.bDragFullWindows = SpiLoadInt(KEY_DESKTOP, VAL_DRAG, 0);
311301
gspv.iWheelScrollLines = SpiLoadInt(KEY_DESKTOP, VAL_SCRLLLINES, 3);

win32ss/user/ntuser/sysparams.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,6 @@ typedef struct _SPIVALUES
157157
DWORD dwForegroundFlashCount;
158158
DWORD dwCaretWidth;
159159

160-
INT nIconSize;
161-
INT nSmallIconSize;
162-
163160
// SPI_LANGDRIVER
164161
// SPI_SETDESKPATTERN
165162
// SPI_SETPENWINDOWS

0 commit comments

Comments
 (0)