Skip to content

Commit 43d07fe

Browse files
authored
[SHELL32] File Types dialog: Add functionality, optimize loading time (reactos#6122)
- Support loading protocols like XP - Support most of the relevant EditFlags - Support reading/writing the AlwaysShowExt and BrowserFlags properties - Loads the list much faster with optimized code and delaying the large icon and description string - Reduce the number of magic buffer sizes by replacing them with defines that are in the ballpark of being correct - Implemented column sorting - Removed custom icon extraction code - Removed IDS_FILE_EXT_TYPE string because it must be the same as IDS_ANY_FILE - Don't touch verb keys that are not edited to retain the original REG type - Don't clobber unchanged %1 icon location when editing a type CORE-19756
1 parent 798ea90 commit 43d07fe

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+820
-696
lines changed

dll/win32/shell32/CDefaultContextMenu.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,6 @@ SHELL_GetRegCLSID(HKEY hKey, LPCWSTR SubKey, LPCWSTR Value, CLSID &clsid)
2323
return !err ? CLSIDFromString(buf, &clsid) : HRESULT_FROM_WIN32(err);
2424
}
2525

26-
static inline bool RegValueExists(HKEY hKey, LPCWSTR Name)
27-
{
28-
return RegQueryValueExW(hKey, Name, NULL, NULL, NULL, NULL) == ERROR_SUCCESS;
29-
}
30-
3126
static BOOL InsertMenuItemAt(HMENU hMenu, UINT Pos, UINT Flags)
3227
{
3328
MENUITEMINFOW mii;

0 commit comments

Comments
 (0)