[SHELL32] Fix broken delete file type verb (reactos#7462)

whindsaks · web-flow · commit 579734016454 · 2024-10-18T14:42:08.000+02:00
CORE-19809
diff --git a/dll/win32/shell32/dialogs/filetypes.cpp b/dll/win32/shell32/dialogs/filetypes.cpp
@@ -1161,7 +1161,7 @@ EditTypeDlg_WriteClass(HWND hwndDlg, PEDITTYPE_DIALOG pEditType,
     BOOL OnlyExt = hr != S_OK;
     HKEY hClassKey;
     if (FAILED(hr) || RegCreateKeyExW(HKEY_CLASSES_ROOT, ClassKey, 0, NULL, 0,
-                                      KEY_QUERY_VALUE |KEY_WRITE, NULL,
+                                      KEY_QUERY_VALUE | KEY_WRITE, NULL,
                                       &hClassKey, NULL) != ERROR_SUCCESS)
     {
         return FALSE;
@@ -1221,7 +1221,7 @@ EditTypeDlg_WriteClass(HWND hwndDlg, PEDITTYPE_DIALOG pEditType,
     }
 
     HKEY hShellKey;
-    if (RegCreateKeyExW(hClassKey, L"shell", 0, NULL, 0, KEY_WRITE, NULL,
+    if (RegCreateKeyExW(hClassKey, L"shell", 0, NULL, 0, KEY_READ | KEY_WRITE, NULL,
                         &hShellKey, NULL) != ERROR_SUCCESS)
     {
         RegCloseKey(hClassKey);

Original file line number	Diff line number	Diff line change
`@@ -1161,7 +1161,7 @@ EditTypeDlg_WriteClass(HWND hwndDlg, PEDITTYPE_DIALOG pEditType,`
`1161`	`1161`	`BOOL OnlyExt = hr != S_OK;`
`1162`	`1162`	`HKEY hClassKey;`
`1163`	`1163`	`if (FAILED(hr) \|\| RegCreateKeyExW(HKEY_CLASSES_ROOT, ClassKey, 0, NULL, 0,`
`1164`		`- KEY_QUERY_VALUE \|KEY_WRITE, NULL,`
	`1164`	`+ KEY_QUERY_VALUE \| KEY_WRITE, NULL,`
`1165`	`1165`	`&hClassKey, NULL) != ERROR_SUCCESS)`
`1166`	`1166`	`{`
`1167`	`1167`	`return FALSE;`
`@@ -1221,7 +1221,7 @@ EditTypeDlg_WriteClass(HWND hwndDlg, PEDITTYPE_DIALOG pEditType,`
`1221`	`1221`	`}`
`1222`	`1222`
`1223`	`1223`	`HKEY hShellKey;`
`1224`		`- if (RegCreateKeyExW(hClassKey, L"shell", 0, NULL, 0, KEY_WRITE, NULL,`
	`1224`	`+ if (RegCreateKeyExW(hClassKey, L"shell", 0, NULL, 0, KEY_READ \| KEY_WRITE, NULL,`
`1225`	`1225`	`&hShellKey, NULL) != ERROR_SUCCESS)`
`1226`	`1226`	`{`
`1227`	`1227`	`RegCloseKey(hClassKey);`