Skip to content

Commit 6762703

Browse files
authored
[PSDK][INCLUDE/WINE] Introduce our own shlwapi.h for PSDK and import wine-10.0 shlwapi.h for Wine code (reactos#8419)
- [PSDK] Introduce our own Microsoft compatible and MIT-licensed shlwapi.h and fix breaking changes - [INCLUDE/WINE] Import shlwapi.h from wine-10.0 for use with Wine compatible code - [CMAKELISTS.TXT] Bump up IE version from IE60 to IE60SP2. This is required because we are already using IE60SP2 guarded functionality; the new header unhides this. - [SHLWAPI] Fix breaking changes, including a typo for 'SHGVSPB_GLOBALDEAFAULTS' (should be 'SHGVSPB_GLOBALDEFAULTS') - [MSI] Use wine's shlwapi.h instead of our own in automation.c, don't precompile shlwapi.h. - [URLMON_WINETEST] Primarily use wineheaders for this test
1 parent bfee65f commit 6762703

File tree

10 files changed

+2365
-2023
lines changed

10 files changed

+2365
-2023
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ Enable this if the module uses typeid or dynamic_cast. You will probably need to
238238

239239
# Version Options
240240
add_definitions(-DWINVER=0x502
241-
-D_WIN32_IE=0x600
241+
-D_WIN32_IE=0x603
242242
-D_WIN32_WINNT=0x502
243243
-D_WIN32_WINDOWS=0x502
244244
-D_SETUPAPI_VER=0x502

dll/win32/msi/automation.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,11 @@
3030
#include "msipriv.h"
3131
#include "activscp.h"
3232
#include "oleauto.h"
33+
#ifdef __REACTOS__
34+
#include "wine/shlwapi.h"
35+
#else
3336
#include "shlwapi.h"
37+
#endif
3438
#include "wine/debug.h"
3539

3640
#include "msiserver.h"

dll/win32/msi/precomp.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@
2121
#include <wincon.h>
2222
#include <msiserver.h>
2323
#include <shlobj.h>
24+
#ifndef __REACTOS__
2425
#include <shlwapi.h>
26+
#endif
2527
#include <sddl.h>
2628

2729
#include <wine/unicode.h>

dll/win32/shlwapi/ordinal.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3067,7 +3067,11 @@ BOOL WINAPI GUIDFromStringW(LPCWSTR idstr, CLSID *id)
30673067
* either set to TRUE, or removed depending on whether the browser is deemed
30683068
* to be integrated.
30693069
*/
3070+
#ifdef __REACTOS__
3071+
UINT WINAPI WhichPlatform(void)
3072+
#else
30703073
DWORD WINAPI WhichPlatform(void)
3074+
#endif
30713075
{
30723076
static const char szIntegratedBrowser[] = "IntegratedBrowser";
30733077
static DWORD dwState = 0;

dll/win32/shlwapi/propbag.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1392,7 +1392,7 @@ BOOL CViewStatePropertyBag::_CanAccessGlobalDefaultsBag() const
13921392
if (_CanAccessFolderDefaultsBag())
13931393
return TRUE;
13941394

1395-
return ((m_dwVspbFlags & SHGVSPB_GLOBALDEAFAULTS) == SHGVSPB_GLOBALDEAFAULTS);
1395+
return ((m_dwVspbFlags & SHGVSPB_GLOBALDEFAULTS) == SHGVSPB_GLOBALDEFAULTS);
13961396
}
13971397

13981398
BOOL CViewStatePropertyBag::_CanAccessInheritBag() const
@@ -1417,7 +1417,7 @@ void CViewStatePropertyBag::_ResetTryAgainFlag()
14171417
m_bUserDefaultsBag = FALSE;
14181418
else if ((m_dwVspbFlags & SHGVSPB_ALLUSERS) && (m_dwVspbFlags & SHGVSPB_PERFOLDER))
14191419
m_bFolderDefaultsBag = FALSE;
1420-
else if ((m_dwVspbFlags & SHGVSPB_GLOBALDEAFAULTS) == SHGVSPB_GLOBALDEAFAULTS)
1420+
else if ((m_dwVspbFlags & SHGVSPB_GLOBALDEFAULTS) == SHGVSPB_GLOBALDEFAULTS)
14211421
m_bGlobalDefaultsBag = FALSE;
14221422
}
14231423

@@ -1678,7 +1678,7 @@ BOOL CViewStatePropertyBag::_EnsureGlobalDefaultsBag(DWORD dwMode, REFIID riid)
16781678
if (!m_pGlobalDefaultsBag && !m_bGlobalDefaultsBag && _CanAccessGlobalDefaultsBag())
16791679
{
16801680
m_bGlobalDefaultsBag = TRUE;
1681-
_CreateBag(NULL, m_pszPath, SHGVSPB_GLOBALDEAFAULTS, dwMode, riid, &m_pGlobalDefaultsBag);
1681+
_CreateBag(NULL, m_pszPath, SHGVSPB_GLOBALDEFAULTS, dwMode, riid, &m_pGlobalDefaultsBag);
16821682
}
16831683
return (m_pGlobalDefaultsBag != NULL);
16841684
}

modules/rostests/winetests/urlmon/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11

2+
include_directories(BEFORE ${REACTOS_SOURCE_DIR}/sdk/include/wine)
23
add_definitions(-D__ROS_LONG64__)
34
add_definitions(-DUSE_WINE_TODOS)
45

0 commit comments

Comments
 (0)