[USBPORT] USBPORT_InvalidateEndpointHandler(): Properly enumerate endpoints

SergeGautherie · Extravert-ir · commit ed9f0dca14ea · 2019-09-29T13:39:12.000+03:00
diff --git a/drivers/usb/usbport/endpoint.c b/drivers/usb/usbport/endpoint.c
@@ -1357,9 +1357,9 @@ USBPORT_InvalidateEndpointHandler(IN PDEVICE_OBJECT FdoDevice,
     {
         KeAcquireSpinLock(&FdoExtension->EndpointListSpinLock, &OldIrql);
 
-        Entry = &FdoExtension->EndpointList;
-
-        while (Entry && Entry != &FdoExtension->EndpointList)
+        for (Entry = FdoExtension->EndpointList.Flink;
+             Entry && Entry != &FdoExtension->EndpointList;
+             Entry = Entry->Flink)
         {
             endpoint = CONTAINING_RECORD(Entry,
                                          USBPORT_ENDPOINT,
@@ -1376,8 +1376,6 @@ USBPORT_InvalidateEndpointHandler(IN PDEVICE_OBJECT FdoDevice,
                     IsAddEntry = TRUE;
                 }
             }
-
-            Entry = endpoint->EndpointLink.Flink;
         }
 
         KeReleaseSpinLock(&FdoExtension->EndpointListSpinLock, OldIrql);

Original file line number	Diff line number	Diff line change
`@@ -1357,9 +1357,9 @@ USBPORT_InvalidateEndpointHandler(IN PDEVICE_OBJECT FdoDevice,`
`1357`	`1357`	`{`
`1358`	`1358`	`KeAcquireSpinLock(&FdoExtension->EndpointListSpinLock, &OldIrql);`
`1359`	`1359`
`1360`		`- Entry = &FdoExtension->EndpointList;`
`1361`		`-`
`1362`		`- while (Entry && Entry != &FdoExtension->EndpointList)`
	`1360`	`+ for (Entry = FdoExtension->EndpointList.Flink;`
	`1361`	`+ Entry && Entry != &FdoExtension->EndpointList;`
	`1362`	`+ Entry = Entry->Flink)`
`1363`	`1363`	`{`
`1364`	`1364`	`endpoint = CONTAINING_RECORD(Entry,`
`1365`	`1365`	`USBPORT_ENDPOINT,`
`@@ -1376,8 +1376,6 @@ USBPORT_InvalidateEndpointHandler(IN PDEVICE_OBJECT FdoDevice,`
`1376`	`1376`	`IsAddEntry = TRUE;`
`1377`	`1377`	`}`
`1378`	`1378`	`}`
`1379`		`-`
`1380`		`- Entry = endpoint->EndpointLink.Flink;`
`1381`	`1379`	`}`
`1382`	`1380`
`1383`	`1381`	`KeReleaseSpinLock(&FdoExtension->EndpointListSpinLock, OldIrql);`