some more small CodecMod tweaks

Author: programminghoch10

CodecMod/src/main/java/com/programminghoch10/CodecMod/CodecStore.java

@@ -2,6 +2,7 @@
 
 import static android.content.Context.MODE_WORLD_READABLE;
 
+import android.annotation.SuppressLint;
 import android.content.Context;
 import android.content.SharedPreferences;
 import android.os.Build;
@@ -18,6 +19,7 @@ public class CodecStore {
     SharedPreferences sharedPreferences;
     List<OnCodecPreferenceChangedListenerMeta> receivers = new LinkedList<>();
 
+    @SuppressLint("WorldReadableFiles")
     CodecStore(Context context) {
         this.sharedPreferences = context.getSharedPreferences(PREFERENCES, MODE_WORLD_READABLE);
     }
@@ -71,7 +73,7 @@ interface OnCodecPreferenceChangedListener {
         void onCodecPreferenceChanged(boolean value);
     }
 
-    private class OnCodecPreferenceChangedListenerMeta {
+    private static class OnCodecPreferenceChangedListenerMeta {
         MediaCodecInfoWrapper mediaCodecInfo;
         OnCodecPreferenceChangedListener callback;
     }

CodecMod/src/main/java/com/programminghoch10/CodecMod/Hook.java

@@ -1,5 +1,6 @@
 package com.programminghoch10.CodecMod;
 
+import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.media.MediaCodecInfo;
 import android.media.MediaCodecList;
@@ -28,6 +29,7 @@ MediaCodecInfo[] getFilteredMediaCodecInfos(MediaCodecInfo[] unfilteredMediaCode
     }
 
     // helper function, only to be used on <LOLLIPOP
+    @SuppressLint("UseRequiresApi")
     @TargetApi(Build.VERSION_CODES.KITKAT_WATCH)
     MediaCodecInfo[] getFilteredMediaCodecInfos() throws InvocationTargetException, IllegalAccessException {
         List<MediaCodecInfo> mediaCodecs = new LinkedList<>();
@@ -40,10 +42,6 @@ MediaCodecInfo[] getFilteredMediaCodecInfos() throws InvocationTargetException,
     @Override
     public void handleLoadPackage(XC_LoadPackage.LoadPackageParam lpparam) throws Throwable {
         if (lpparam.packageName.equals(BuildConfig.APPLICATION_ID)) return;
-        if (lpparam.packageName.equals("android")) {
-            // system-wide hooking not implemented
-            return;
-        }
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
             XposedHelpers.findAndHookMethod(MediaCodecList.class, "getCodecInfos", new XC_MethodReplacement() {
                 @Override

CodecMod/src/main/java/com/programminghoch10/CodecMod/SettingsActivity.java

@@ -41,7 +41,7 @@ public static class SettingsFragment extends PreferenceFragmentCompat {
         public void onCreatePreferences(Bundle savedInstanceState, String rootKey) {
             setPreferencesFromResource(R.xml.root_preferences, rootKey);
             //getPreferenceManager().setSharedPreferencesName("codecs");
-            CodecStore codecStore = new CodecStore(getContext());
+            CodecStore codecStore = new CodecStore(requireContext());
             PreferenceCategory decodersPreferenceCategory = findPreference("category_decoders");
             PreferenceCategory encodersPreferenceCategory = findPreference("category_encoders");
 
@@ -58,7 +58,7 @@ public void onCreatePreferences(Bundle savedInstanceState, String rootKey) {
             }
             for (MediaCodecInfoWrapper mediaCodecInfo : mediaCodecs) {
                 if (mediaCodecInfo.isAlias() && !SHOW_ALIASES) continue;
-                SwitchPreference preference = new SwitchPreference(getContext());
+                SwitchPreference preference = new SwitchPreference(requireContext());
                 preference.setPersistent(false);
                 preference.setDefaultValue(CodecStore.DEFAULT_VALUE);
                 preference.setKey(CodecStore.getKey(mediaCodecInfo));