Not functional for BD on Windows

[Yentis]

Some issues I encountered trying this plugin:

• doesn't work for embeds, only plain urls
• setup.sh doesn't download a file, just opens a page and user needs to right click -> save as
• windows machines can't run sh files by default (needs something like git installed)
• the context menu button doesn't work, it opens a command prompt that just throws an error
  
  

[Joshix-1]

doesn't work for embeds, only plain urls

Good idea, that would be a new feature

setup.sh doesn't download a file, just opens a page and user needs to right click -> save as

I'm not aware of a solution to this problem. Browser extensions cannot install files locally.

windows machines can't run sh files by default (needs something like git installed)

Windows is not supported.

the context menu button doesn't work, it opens a command prompt that just throws an error

Windows is not supported.

[Yentis]

This plugin was submitted to BetterDiscord (https://betterdiscord.app/plugin/open%20in%20mpv), discord's userbase is predominantly Windows so it should be supported or at least mentioned very clearly that it's not supported.

I'm not aware of a solution to this problem. Browser extensions cannot install files locally.

A BD plugin can use fs.writeFile (https://docs.betterdiscord.app/plugins/introduction/environment#node-js)

[binarynoise]

I put it onto the post-publishing TODO.

As we don't use Windows, adding this feature is not a priority, however it seems doable.
A first start would be https://stackoverflow.com/questions/80650/how-do-i-register-a-custom-url-protocol-in-windows

[binarynoise]

the context menu button doesn't work, it opens a command prompt that just throws an error

Did you, @Yentis, at some point instruct windows to use cmd to handle the mpv:// url?

[Yentis]

Yes, I had a protocol registered in the past. I removed the remnants of it and now it shows this instead:

No app can be selected.

[binarynoise]

good, I'll experiment with windows when I find some time.