Skip to content

Commit 4ae6c43

Browse files
committed
优化代码,规范变量命名
1 parent 9149cd4 commit 4ae6c43

File tree

4 files changed

+21
-24
lines changed

4 files changed

+21
-24
lines changed

weixin-java-mp/src/main/java/me/chanjar/weixin/mp/bean/kefu/WxMpKefuMessage.java

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package me.chanjar.weixin.mp.bean.kefu;
22

3+
import lombok.AllArgsConstructor;
34
import lombok.Data;
5+
import lombok.NoArgsConstructor;
46
import me.chanjar.weixin.common.api.WxConsts;
57
import me.chanjar.weixin.mp.builder.kefu.*;
68
import me.chanjar.weixin.mp.util.json.WxMpGsonBuilder;
@@ -35,12 +37,11 @@ public class WxMpKefuMessage implements Serializable {
3537
private String headContent;
3638
private String tailContent;
3739
private List<WxArticle> articles = new ArrayList<>();
38-
private List<WxMsgMenu> list = new ArrayList<>();
40+
3941
/**
4042
* 菜单消息里的菜单内容.
41-
* 请使用逗号分割的形式将id和content连起来放在数组的里面
4243
*/
43-
private String[] msgMenuList;
44+
private List<MsgMenu> msgMenus = new ArrayList<>();
4445

4546
/**
4647
* 获得文本消息builder.
@@ -137,6 +138,8 @@ public String toJson() {
137138
}
138139

139140
@Data
141+
@AllArgsConstructor
142+
@NoArgsConstructor
140143
public static class WxArticle implements Serializable {
141144
private static final long serialVersionUID = 5145137235440507379L;
142145

@@ -147,7 +150,11 @@ public static class WxArticle implements Serializable {
147150
}
148151

149152
@Data
150-
public static class WxMsgMenu implements Serializable {
153+
@AllArgsConstructor
154+
@NoArgsConstructor
155+
public static class MsgMenu implements Serializable {
156+
private static final long serialVersionUID = 7020769047598378839L;
157+
151158
private String id;
152159
private String content;
153160
}

weixin-java-mp/src/main/java/me/chanjar/weixin/mp/builder/kefu/WxMsgMenuBuilder.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@
1111
* 菜单消息builder
1212
* <pre>
1313
* 用法:
14-
* WxMpKefuMessage m = WxMpKefuMessage.MSGMENU().addList(lists).headContent(headContent).tailContent(tailContent).toUser(...).build();
14+
* WxMpKefuMessage m = WxMpKefuMessage.MSGMENU().addMenus(lists).headContent(headContent).tailContent(tailContent).toUser(...).build();
1515
* </pre>
1616
*
1717
* @author billytomato
1818
*/
1919
public final class WxMsgMenuBuilder extends BaseBuilder<WxMsgMenuBuilder> {
20-
private List<WxMpKefuMessage.WxMsgMenu> list = new ArrayList<>();
20+
private List<WxMpKefuMessage.MsgMenu> msgMenus = new ArrayList<>();
2121
private String headContent;
2222
private String tailContent;
2323

@@ -26,13 +26,13 @@ public WxMsgMenuBuilder() {
2626
this.msgType = WxConsts.KefuMsgType.MSGMENU;
2727
}
2828

29-
public WxMsgMenuBuilder addList(WxMpKefuMessage.WxMsgMenu... list) {
30-
Collections.addAll(this.list, list);
29+
public WxMsgMenuBuilder addMenus(WxMpKefuMessage.MsgMenu... msgMenus) {
30+
Collections.addAll(this.msgMenus, msgMenus);
3131
return this;
3232
}
3333

34-
public WxMsgMenuBuilder list(List<WxMpKefuMessage.WxMsgMenu> list) {
35-
this.list = list;
34+
public WxMsgMenuBuilder msgMenus(List<WxMpKefuMessage.MsgMenu> msgMenus) {
35+
this.msgMenus = msgMenus;
3636
return this;
3737
}
3838

@@ -51,7 +51,7 @@ public WxMpKefuMessage build() {
5151
WxMpKefuMessage m = super.build();
5252
m.setHeadContent(this.headContent);
5353
m.setTailContent(this.tailContent);
54-
m.setList(this.list);
54+
m.setMsgMenus(this.msgMenus);
5555
return m;
5656
}
5757
}

weixin-java-mp/src/main/java/me/chanjar/weixin/mp/util/json/WxMpKefuMessageGsonAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public JsonElement serialize(WxMpKefuMessage message, Type typeOfSrc, JsonSerial
8383
case KefuMsgType.MSGMENU: {
8484
JsonObject msgmenuJsonObject = new JsonObject();
8585
JsonArray listJsonArray = new JsonArray();
86-
for (WxMpKefuMessage.WxMsgMenu list : message.getList()) {
86+
for (WxMpKefuMessage.MsgMenu list : message.getMsgMenus()) {
8787
JsonObject listJson = new JsonObject();
8888
listJson.addProperty("id", list.getId());
8989
listJson.addProperty("content", list.getContent());

weixin-java-mp/src/test/java/me/chanjar/weixin/mp/bean/kefu/WxMpKefuMessageTest.java

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
import org.testng.Assert;
66
import org.testng.annotations.Test;
77

8-
import static org.assertj.core.api.Assertions.assertThat;
9-
108
@Test
119
public class WxMpKefuMessageTest {
1210

@@ -156,18 +154,10 @@ public void testMiniProgramPageBuild() {
156154
}
157155

158156
public void testMsgMenuBuild() {
159-
160-
WxMpKefuMessage.WxMsgMenu wxMsgMenu1=new WxMpKefuMessage.WxMsgMenu();
161-
wxMsgMenu1.setId("101");
162-
wxMsgMenu1.setContent("msgmenu1");
163-
164-
WxMpKefuMessage.WxMsgMenu wxMsgMenu2=new WxMpKefuMessage.WxMsgMenu();
165-
wxMsgMenu2.setId("102");
166-
wxMsgMenu2.setContent("msgmenu2");
167-
168157
WxMpKefuMessage reply = WxMpKefuMessage.MSGMENU()
169158
.toUser("OPENID")
170-
.addList(wxMsgMenu1).addList(wxMsgMenu2)
159+
.addMenus(new WxMpKefuMessage.MsgMenu("101", "msgmenu1"),
160+
new WxMpKefuMessage.MsgMenu("102", "msgmenu2"))
171161
.headContent("head_content")
172162
.tailContent("tail_content")
173163
.build();

0 commit comments

Comments
 (0)