Skip to content

Commit 5c7b6d2

Browse files
committed
🎨 优化部分代码
1 parent 50e50c1 commit 5c7b6d2

File tree

2 files changed

+25
-30
lines changed

2 files changed

+25
-30
lines changed

weixin-graal/src/main/java/cn/binarywang/wx/graal/GraalProcessor.java

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package cn.binarywang.wx.graal;
22

33
import lombok.Data;
4+
import lombok.extern.slf4j.Slf4j;
45

56
import javax.annotation.processing.AbstractProcessor;
67
import javax.annotation.processing.RoundEnvironment;
@@ -25,7 +26,6 @@
2526
*
2627
* @author outersky
2728
*/
28-
2929
@SupportedAnnotationTypes("lombok.Data")
3030
@SupportedSourceVersion(SourceVersion.RELEASE_7)
3131
public class GraalProcessor extends AbstractProcessor {
@@ -38,7 +38,6 @@ public class GraalProcessor extends AbstractProcessor {
3838
@Override
3939
public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment roundEnv) {
4040
for (TypeElement annotatedClass : ElementFilter.typesIn(roundEnv.getElementsAnnotatedWith(Data.class))) {
41-
4241
registerClass(annotatedClass.getQualifiedName().toString());
4342
handleSuperClass(annotatedClass);
4443
}
@@ -108,29 +107,29 @@ private void writeFiles() {
108107
String propsFile = path + NATIVE_IMAGE_PROPERTIES;
109108
try {
110109
FileObject fileObject = processingEnv.getFiler().createResource(StandardLocation.CLASS_OUTPUT, "", propsFile);
111-
Writer writer = fileObject.openWriter();
112-
writer.append("Args = -H:ReflectionConfigurationResources=${.}/" + REFLECTION_CONFIG_JSON);
113-
writer.close();
110+
try (Writer writer = fileObject.openWriter();) {
111+
writer.append("Args = -H:ReflectionConfigurationResources=${.}/" + REFLECTION_CONFIG_JSON);
112+
}
114113
} catch (IOException e) {
115114
e.printStackTrace();
116115
}
117116

118117
try {
119118
FileObject fileObject = processingEnv.getFiler().createResource(StandardLocation.CLASS_OUTPUT, "", reflectFile);
120-
Writer writer = fileObject.openWriter();
121-
writer.write("[\n");
122-
boolean first = true;
123-
for (String name : classSet) {
124-
if (first) {
125-
first = false;
126-
} else {
127-
writer.write(",");
119+
try (Writer writer = fileObject.openWriter();) {
120+
writer.write("[\n");
121+
boolean first = true;
122+
for (String name : classSet) {
123+
if (first) {
124+
first = false;
125+
} else {
126+
writer.write(",");
127+
}
128+
writer.write(assetGraalJsonElement(name));
129+
writer.append('\n');
128130
}
129-
writer.write(assetGraalJsonElement(name));
130-
writer.append('\n');
131+
writer.write("]");
131132
}
132-
writer.write("]");
133-
writer.close();
134133
} catch (IOException e) {
135134
e.printStackTrace();
136135
}

weixin-java-common/src/main/java/me/chanjar/weixin/common/session/StandardSessionManager.java

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,19 @@
11
package me.chanjar.weixin.common.session;
22

3-
import java.util.Map;
4-
import java.util.concurrent.ConcurrentHashMap;
5-
import java.util.concurrent.atomic.AtomicBoolean;
6-
3+
import me.chanjar.weixin.common.util.res.StringManager;
74
import org.slf4j.Logger;
85
import org.slf4j.LoggerFactory;
96

10-
import me.chanjar.weixin.common.util.res.StringManager;
7+
import java.util.Map;
8+
import java.util.concurrent.ConcurrentHashMap;
9+
import java.util.concurrent.atomic.AtomicBoolean;
1110

1211
/**
1312
* 基于内存的session manager.
1413
*
1514
* @author Daniel Qian
1615
*/
1716
public class StandardSessionManager implements WxSessionManager, InternalSessionManager {
18-
1917
protected static final StringManager SM = StringManager.getManager(Constants.PACKAGE);
2018
/**
2119
* The descriptive name of this Manager implementation (for logging).
@@ -51,7 +49,9 @@ public class StandardSessionManager implements WxSessionManager, InternalSession
5149
*/
5250
protected int maxInactiveInterval = 30 * 60;
5351

54-
// Number of sessions created by this manager
52+
/**
53+
* Number of sessions created by this manager
54+
*/
5555
protected long sessionCounter = 0;
5656

5757
protected volatile int maxActive = 0;
@@ -154,12 +154,10 @@ public InternalSession createSession(String sessionId) {
154154
session.setValid(true);
155155
session.setCreationTime(System.currentTimeMillis());
156156
session.setMaxInactiveInterval(this.maxInactiveInterval);
157-
String id = sessionId;
158-
session.setId(id);
157+
session.setId(sessionId);
159158
this.sessionCounter++;
160159

161-
return (session);
162-
160+
return session;
163161
}
164162

165163

@@ -181,10 +179,8 @@ protected InternalSession getNewSession() {
181179
return new StandardSession(this);
182180
}
183181

184-
185182
@Override
186183
public void add(InternalSession session) {
187-
188184
// 当第一次有session创建的时候,开启session清理线程
189185
if (!this.backgroundProcessStarted.getAndSet(true)) {
190186
Thread t = new Thread(new Runnable() {

0 commit comments

Comments
 (0)