-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Labels
Bioscrape CoreIssues pertaining to core bioscrape functionalityIssues pertaining to core bioscrape functionalityLineagesIssues pertaining to bioscrape lineagesIssues pertaining to bioscrape lineagesdocumentationSoftware and example documentationSoftware and example documentationinvalidThis doesn't seem rightThis doesn't seem right
Description
In multiple SSA algorithms, we have species counts stored as doubles. This allows an unwary user (such as myself) to start a simulation with non-integer species counts. If you do that, it's not too difficult to get a negative species count --> negative reaction propensity --> negative time of next reaction --> infinite loop that can't be interrupted in an ipython kernel.
I assume this is done to avoid conversions between ints and doubles, for speed reasons? We might want to put a check in place at the beginning of these simulate functions to make sure all species counts are reasonably close to an integer (maybe just round them all to ints and cast them back to doubles?).
Metadata
Metadata
Assignees
Labels
Bioscrape CoreIssues pertaining to core bioscrape functionalityIssues pertaining to core bioscrape functionalityLineagesIssues pertaining to bioscrape lineagesIssues pertaining to bioscrape lineagesdocumentationSoftware and example documentationSoftware and example documentationinvalidThis doesn't seem rightThis doesn't seem right