Close #192: use variable for long string literals in exceptions

Author: Reece Hart

pyproject.toml

@@ -201,8 +201,6 @@ select = [
   "A001", # Variable `id` is shadowing a Python builtin
   "A002", # Function argument `id` is shadowing a Python builtin
   "B006", # Do not use mutable data structures for argument defaults
-  "EM101", # Exception must not use a string literal, assign to variable first
-  "EM102", # Exception must not use an f-string literal, assign to variable first
   "F522", # `.format` call has unused named argument(s): n
   "F524", # `.format` call is missing argument(s) for placeholder(s): n=n
   "F821", # Undefined name `pas`

src/biocommons/eutils/_internal/client.py

@@ -86,7 +86,8 @@ def efetch(self, db, id):
             return ExchangeSet(xml)
         if db in ["pmc"]:
             return PubmedCentralArticleSet(doc)
-        raise EutilsError(f"database {db} is not currently supported by eutils")
+        msg = f"database {db} is not currently supported by eutils"
+        raise EutilsError(msg)
 
 
 # <LICENSE>

src/biocommons/eutils/_internal/xmlfacades/base.py

@@ -31,11 +31,11 @@ def __init__(self, xml):
             raise EutilsError("Cannot create object from type " + type(xml).__name__)
 
         if self._root_tag is None:
-            raise EutilsError(f"_root_tag not defined for class {type(self).__name__}")
+            msg = f"_root_tag not defined for class {type(self).__name__}"
+            raise EutilsError(msg)
         if self._root_tag != self._xml_root.tag:
-            raise EutilsError(
-                f"XML for {type(self).__name__} object must be a {self._root_tag} element (got {self._xml_root.tag})"
-            )
+            msg = f"XML for {type(self).__name__} object must be a {self._root_tag} element (got {self._xml_root.tag})"
+            raise EutilsError(msg)
 
 
 # <LICENSE>

src/biocommons/eutils/_internal/xmlfacades/einforesult.py

@@ -30,7 +30,8 @@ def type(self):
             return "dbinfo"
         if childtag == "DbList":
             return "dblist"
-        raise RuntimeError("Shouldn't be here; EInfoResult contains neither a DbList nor a DbInfo")
+        msg = "Shouldn't be here; EInfoResult contains neither a DbList nor a DbInfo"
+        raise RuntimeError(msg)
 
     @property
     def dbinfo(self):

src/biocommons/eutils/_internal/xmlfacades/gbseq.py

@@ -49,7 +49,8 @@ def gene(self):
 
     @property
     def genes(self):
-        raise RuntimeError("The genes property is obsolete; use gene instead")
+        msg = "The genes property is obsolete; use gene instead"
+        raise RuntimeError(msg)
 
     @property
     def gi(self):

src/biocommons/eutils/_internal/xmlfacades/genecommentary.py

@@ -34,9 +34,8 @@ def acv(self):
     def genomic_coords(self):
         n = self._xml_root.find("Gene-commentary_genomic-coords")
         if n is None:
-            raise EutilsError(
-                f"this object (type={self.type}) does not have genomic coordinates defined (mRNA and peptide typically do)"
-            )
+            msg = f"this object (type={self.type}) does not have genomic coordinates defined (mRNA and peptide typically do)"
+            raise EutilsError(msg)
         return GeneCommentaryGenomicCoords(n)
 
     @property