Fix #236

Changes to be committed:
	modified:   api/scripts/method_specific/GET_draft_object_by_id.py
	modified:   api/views.py
	new file:   tests/test_views/test_get_object_id_draft.py

Author: HadleyKing

api/scripts/method_specific/GET_draft_object_by_id.py

@@ -63,11 +63,11 @@ def get_draft_object_by_id(do_id, request):
 
         return Response(
             data="The contents of the draft could not be sent back because"
-            " the requestor did not have appropriate permissions.",
-            status=status.HTTP_403_FORBIDDEN,
+            " the requestor does not have appropriate permissions.",
+            status=status.HTTP_401_UNAUTHORIZED,
         )
     # the root ID does not exist at all.
     return Response(
-        data="The draft could not be found on the server.",
-        status=status.HTTP_400_BAD_REQUEST,
+        data="That draft could not be found on the server.",
+        status=status.HTTP_404_NOT_FOUND,
     )

api/views.py

@@ -1638,16 +1638,10 @@ class DraftObjectId(APIView):
 
     --------------------
 
-    Reads and returns and object based on a URI.
+    Reads and returns a single object from a given object_id.
 
     """
 
-    # For the success and error messages
-    # renderer_classes = [
-    #     TemplateHTMLRenderer
-    # ]
-    # template_name = 'api/account_activation_message.html'
-
     auth = []
     auth.append(
         openapi.Parameter(
@@ -1661,10 +1655,12 @@ class DraftObjectId(APIView):
     @swagger_auto_schema(
         manual_parameters=auth,
         responses={
-            201: "Account has been authorized.",
-            208: "Account has already been authorized.",
-            403: "Requestor's credentials were rejected.",
-            424: "Account has not been registered.",
+            200: "Success. Object contents returned",
+            401: "The contents of the draft could not be sent back because"
+                " the requestor does not have appropriate permissions.",
+            403: "Forbidden. Authentication credentials were not provided, or"
+                " the token was invalid.",
+            404: "Not found. That draft could not be found on the server."
         },
         tags=["BCO Management"],
     )

tests/test_views/test_get_object_id_draft.py

@@ -0,0 +1,53 @@
+
+#!/usr/bin/env python3
+
+""" Get Draft BCO
+
+"""
+
+import unittest
+from django.test import TestCase
+from rest_framework.test import APIClient
+from rest_framework.authtoken.models import Token
+from django.contrib.auth.models import User
+
+class GetDraftBcoTestCase(TestCase):
+    fixtures = ['tests/fixtures/test_data']
+
+    def setUp(self):
+        self.client = APIClient()
+
+    def test_get_draft(self):
+        """Test a successful response with status code 201
+        """
+        token = Token.objects.get(user=User.objects.get(username='test50')).key
+        self.client.credentials(HTTP_AUTHORIZATION='Token ' + token)
+        response = self.client.get('/BCO_000000/DRAFT', format='json')
+        self.assertEqual(response.status_code, 200)
+    
+    def test_no_credentials(self):
+        """Test for '403: Authentication credentials were not provided.'
+        """
+
+        response = self.client.get('/BCO_000000/DRAFT', format='json')
+        self.assertEqual(response.status_code, 403)
+
+    def test_dne(self):
+        """Test for '404: Not found. That draft could not be found on the
+        server.'
+        """
+        
+        token = Token.objects.get(user=User.objects.get(username='test50')).key
+        self.client.credentials(HTTP_AUTHORIZATION='Token ' + token)
+        response = self.client.get('/BCO_000100/DRAFT', format='json')
+        self.assertEqual(response.status_code, 404)
+
+    def test_unauthorized(self):
+        """Test for '404: Not found. That draft could not be found on the
+        server.'
+        """
+        
+        token = Token.objects.get(user=User.objects.get(username='test50')).key
+        self.client.credentials(HTTP_AUTHORIZATION='Token ' + token)
+        response = self.client.get('/OTHER_000001/DRAFT', format='json')
+        self.assertEqual(response.status_code, 401)