Skip to content

Commit 6ef4a2d

Browse files
committed
update use of ValidationDetail
1 parent 5cef0f4 commit 6ef4a2d

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

bioimageio/core/_resource_tests.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
)
1616
from bioimageio.spec._internal.common_nodes import ResourceDescrBase
1717
from bioimageio.spec.common import BioimageioYamlContent, PermissiveFileSource
18+
from bioimageio.spec.conda_env import get_conda_env
1819
from bioimageio.spec.model import v0_4, v0_5
1920
from bioimageio.spec.model.v0_5 import WeightsFormat
2021
from bioimageio.spec.summary import (
@@ -189,7 +190,9 @@ def _test_model_inference(
189190
model.validation_summary.add_detail(
190191
ValidationDetail(
191192
name=test_name,
193+
loc=("weights", weight_format),
192194
status="passed" if error is None else "failed",
195+
recommended_env=get_conda_env(entry=dict(model.weights)[weight_format]),
193196
errors=(
194197
[]
195198
if error is None
@@ -332,6 +335,7 @@ def get_ns(n: int):
332335
ValidationDetail(
333336
name=f"Run {weight_format} inference for inputs with"
334337
+ f" batch_size: {batch_size} and size parameter n: {n}",
338+
loc=("weights", weight_format),
335339
status="passed" if error is None else "failed",
336340
errors=(
337341
[]
@@ -353,6 +357,7 @@ def get_ns(n: int):
353357
ValidationDetail(
354358
name=f"Run {weight_format} inference for parametrized inputs",
355359
status="failed",
360+
loc=("weights", weight_format),
356361
errors=[
357362
ErrorEntry(
358363
loc=("weights", weight_format),
@@ -373,6 +378,7 @@ def _test_expected_resource_type(
373378
ValidationDetail(
374379
name="Has expected resource type",
375380
status="passed" if has_expected_type else "failed",
381+
loc=("type",),
376382
errors=(
377383
[]
378384
if has_expected_type

0 commit comments

Comments
 (0)