Test for issue with attachments

Author: constantinpape

bioimageio/core/build_spec/build_model.py

@@ -803,7 +803,6 @@ def build_model(
 
     # optional kwargs, don't pass them if none
     optional_kwargs = {
-        "attachments": attachments,
         "config": config,
         "git_repo": git_repo,
         "packaged_by": packaged_by,
@@ -814,13 +813,23 @@ def build_model(
     }
     kwargs = {k: v for k, v in optional_kwargs.items() if v is not None}
 
+    if attachments is not None:
+        file_attachments = attachments.pop("files", None)
+        # this is my attempt at creating the correct attachments, but this is still not working
+        # (the attachments field is empty after serialization and the content of attachments:files is not copied)
+        # I also tried this and it doesn't work either:
+        # spec.model.schema.Attachments().load({"files": file_attachments})
+        if file_attachments is None:
+            kwargs["attachments"] = model_spec.raw_nodes.Attachments(**attachments)
+        else:
+            kwargs["attachments"] = model_spec.raw_nodes.Attachments(files=file_attachments, **attachments)
     if dependencies is not None:
         kwargs["dependencies"] = _get_dependencies(dependencies, root)
+    if maintainers is not None:
+        kwargs["maintainers"] = [model_spec.raw_nodes.Maintainer(**m) for m in maintainers]
     if parent is not None:
         assert len(parent) == 2
         kwargs["parent"] = {"uri": parent[0], "sha256": parent[1]}
-    if maintainers is not None:
-        kwargs["maintainers"] = [model_spec.raw_nodes.Maintainer(**m) for m in maintainers]
 
     try:
         model = model_spec.raw_nodes.Model(

tests/build_spec/test_build_spec.py

@@ -115,11 +115,24 @@ def _test_build_spec(
             assert sample.exists()
 
     assert loaded_model.maintainers[0].github_user == "jane_doe"
+
     attachments = loaded_model.attachments
     if attachments is not missing and attachments.files is not missing:
-        for attached_file in attachments["files"]:
+        for attached_file in attachments.files:
             assert attached_file.exists()
 
+    # make sure there is one attachment per pre/post-processing
+    if add_deepimagej_config:
+        preproc, postproc = preprocessing[0], postprocessing[0]
+        n_processing = 0
+        if preproc is not None:
+            n_processing += len(preproc)
+        if postproc is not None:
+            n_processing += len(postproc)
+        if n_processing > 0:
+            assert attachments.files is not missing
+            assert n_processing == len(attachments.files)
+
 
 def test_build_spec_pytorch(any_torch_model, tmp_path):
     _test_build_spec(any_torch_model, tmp_path / "model.zip", "pytorch_state_dict")