Merge pull request #469 from bioimage-io/dev

fix model inference tolerance reporting

Author: FynnBe

README.md

@@ -364,6 +364,10 @@ may be controlled with the `LOGURU_LEVEL` environment variable.
 
 ## Changelog
 
+### 0.9.2
+
+fix model inference tolerance reporting
+
 ### 0.9.1
 
 - fixes:

src/bioimageio/core/__init__.py

@@ -3,7 +3,7 @@
 """
 # ruff: noqa: E402
 
-__version__ = "0.9.1"
+__version__ = "0.9.2"
 from loguru import logger
 
 logger.disable("bioimageio.core")

src/bioimageio/core/_resource_tests.py

@@ -24,11 +24,6 @@
 )
 
 import numpy as np
-from loguru import logger
-from numpy.typing import NDArray
-from typing_extensions import NotRequired, TypedDict, Unpack, assert_never, get_args
-
-from bioimageio.core import __version__
 from bioimageio.spec import (
     AnyDatasetDescr,
     AnyModelDescr,
@@ -66,6 +61,11 @@
     ValidationSummary,
     WarningEntry,
 )
+from loguru import logger
+from numpy.typing import NDArray
+from typing_extensions import NotRequired, TypedDict, Unpack, assert_never, get_args
+
+from bioimageio.core import __version__
 
 from ._prediction_pipeline import create_prediction_pipeline
 from .axis import AxisId, BatchSize
@@ -816,9 +816,7 @@ def add_warning_entry(msg: str):
                 r_expected = expected_np[r_max_idx].item()
 
                 # Calculate the max absolute difference with the relative tolerance subtracted
-                abs_diff_wo_rtol: NDArray[np.float32] = (abs_diff - rtol_value).max(
-                    initial=0
-                )
+                abs_diff_wo_rtol: NDArray[np.float32] = abs_diff - rtol_value
                 a_max_idx = np.unravel_index(
                     abs_diff_wo_rtol.argmax(), abs_diff_wo_rtol.shape
                 )