Skip to content

Commit fe8676b

Browse files
committed
fix parametrized model packages
1 parent 3d23a7c commit fe8676b

File tree

2 files changed

+30
-21
lines changed

2 files changed

+30
-21
lines changed

tests/build_spec/test_build_spec.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -68,16 +68,18 @@ def test_build_spec_torchscript(unet2d_nuclei_broad_model):
6868
_test_build_spec(unet2d_nuclei_broad_model, "pytorch_script")
6969

7070

71-
@pytest.mark.skipif(pytest.skip_frunet, reason="pending update to FruNet")
72-
def test_build_spec_keras(FruNet_model):
73-
_test_build_spec(FruNet_model, "keras_hdf5", tensorflow_version="1.12")
71+
@pytest.mark.skipif(pytest.skip_tensorflow or pytest.tf_major_version != 1, reason="requires tensorflow 1")
72+
def test_build_spec_keras(any_keras_model):
73+
_test_build_spec(any_keras_model, "keras_hdf5", tensorflow_version="1.12") # todo: keras for tf 2??
7474

7575

76-
@pytest.mark.skipif(pytest.skip_frunet, reason="pending update to FruNet")
77-
def test_build_spec_tf(FruNet_model):
78-
_test_build_spec(FruNet_model, "tensorflow_saved_model_bundle", tensorflow_version="1.12")
76+
@pytest.mark.skipif(pytest.skip_tensorflow, reason="requires tensorflow")
77+
def test_build_spec_tf(any_tensorflow_model):
78+
_test_build_spec(
79+
any_tensorflow_model, "tensorflow_saved_model_bundle", tensorflow_version="1.12"
80+
) # check tf version
7981

8082

81-
@pytest.mark.skipif(pytest.skip_frunet, reason="pending update to FruNet")
82-
def test_build_spec_tfjs(FruNet_model):
83-
_test_build_spec(FruNet_model, "tensorflow_js", tensorflow_version="1.12")
83+
@pytest.mark.skipif(pytest.skip_tensorflow, reason="requires tensorflow")
84+
def test_build_spec_tfjs(any_tensorflow_js_model):
85+
_test_build_spec(any_tensorflow_js_model, "tensorflow_js", tensorflow_version="1.12")

tests/conftest.py

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
tensorflow1_models = ["FruNet_model"]
99
tensorflow2_models = []
1010
keras_models = ["FruNet_model"]
11+
tensorflow_js_models = ["FruNet_model"]
1112

1213
model_sources = {
1314
"unet2d_nuclei_broad_model": (
@@ -61,11 +62,13 @@ def pytest_configure():
6162
if not pytest.skip_onnx:
6263
load_packages |= set(onnx_models)
6364

64-
if not pytest.skip_tensorflow and pytest.tf_major_version == 1:
65-
load_packages |= set(tensorflow1_models)
66-
67-
if not pytest.skip_tensorflow and pytest.tf_major_version == 2:
68-
load_packages |= set(tensorflow2_models)
65+
if not pytest.skip_tensorflow:
66+
load_packages |= set(keras_models)
67+
load_packages |= set(tensorflow_js_models)
68+
if pytest.tf_major_version == 1:
69+
load_packages |= set(tensorflow1_models)
70+
elif pytest.tf_major_version == 2:
71+
load_packages |= set(tensorflow2_models)
6972

7073
pytest.model_packages = {name: export_resource_package(model_sources[name]) for name in load_packages}
7174

@@ -105,18 +108,22 @@ def any_onnx_model(request):
105108
return pytest.model_packages[request.param]
106109

107110

108-
@pytest.fixture(params=tensorflow1_models)
109-
def any_tensorflow1_model(request):
110-
return pytest.model_packages[request.param]
111+
@pytest.fixture(params=set(tensorflow1_models) | set(tensorflow2_models))
112+
def any_tensorflow_model(request):
113+
name = request.param
114+
if (pytest.tf_major_version == 1 and name in tensorflow1_models) or (
115+
pytest.tf_major_version == 2 and name in tensorflow2_models
116+
):
117+
return pytest.model_packages[name]
111118

112119

113-
@pytest.fixture(params=tensorflow2_models)
114-
def any_tensorflow2_model(request):
120+
@pytest.fixture(params=keras_models)
121+
def any_keras_model(request):
115122
return pytest.model_packages[request.param]
116123

117124

118-
@pytest.fixture(params=keras_models)
119-
def any_keras_model(request):
125+
@pytest.fixture(params=tensorflow_js_models)
126+
def any_tensorflow_js_model(request):
120127
return pytest.model_packages[request.param]
121128

122129

0 commit comments

Comments
 (0)