show source url in error when sha is wrong

Author: FynnBe

bioimageio/spec/_internal/io.py

@@ -705,18 +705,23 @@ def _open_url(
         or hashlib.sha256(str(source).encode(encoding="utf-8")).hexdigest()
     )
 
-    return BytesReader(
-        cache.fetch(
+    try:
+        reader = cache.fetch(
             source,
             fetcher=partial(_fetch_url, progressbar=progressbar),
             force_refetch=digest,
-        ),
-        suffix=source_path.suffix,
-        sha256=sha,
-        original_file_name=source_path.name,
-        original_root=source.parent,
-        is_zipfile=None,
-    )
+        )
+    except Exception as e:
+        raise ValueError(f"Failed to fetch {source}.") from e
+    else:
+        return BytesReader(
+            reader,
+            suffix=source_path.suffix,
+            sha256=sha,
+            original_file_name=source_path.name,
+            original_root=source.parent,
+            is_zipfile=None,
+        )
 
 
 def _fetch_url(

tests/test_internal/test_io.py

@@ -9,7 +9,8 @@
 from respx import MockRouter
 
 from bioimageio.spec import ValidationContext
-from bioimageio.spec._internal.io_basics import ZipPath
+from bioimageio.spec._internal.io_basics import Sha256, ZipPath
+from bioimageio.spec._internal.url import HttpUrl
 from bioimageio.spec.common import RelativeFilePath
 
 
@@ -244,3 +245,15 @@ def test_serialize_relative_file_path_from_union():
     data = file_path.model_dump(mode="json")
 
     assert data == path_str
+
+
+def test_open_url_with_wrong_sha():
+    from bioimageio.spec._internal.io import (
+        _open_url,  # pyright: ignore[reportPrivateUsage]
+    )
+
+    url = "https://example.com/file.txt"
+    sha = Sha256("0" * 64)  # invalid sha256 for testing
+
+    with pytest.raises(ValueError, match=f"Failed to fetch {url}."):
+        _ = _open_url(HttpUrl(url), sha256=sha)