add progressbar for cacheless download

Author: FynnBe

bioimageio/spec/_internal/io.py

@@ -47,6 +47,7 @@
     model_validator,
 )
 from pydantic_core import core_schema
+from tqdm import tqdm
 from typing_extensions import (
     Annotated,
     LiteralString,
@@ -725,10 +726,16 @@ def resolve(
         if settings.user_agent is not None:
             headers["User-Agent"] = settings.user_agent
 
-        if settings.cache_path and not get_validation_context().disable_cache:
+        chunk_size = 1024
+        if (
+            settings.cache_path
+            and not get_validation_context().disable_cache
+            and any(v is not None for v in kwargs.values())
+        ):
             downloader = pooch.HTTPDownloader(
                 headers=headers,
                 progressbar=progressbar,  # pyright: ignore[reportArgumentType]
+                chunk_size=chunk_size,
             )
             fname = _get_unique_file_name(source)
             _ls: Any = pooch.retrieve(
@@ -746,23 +753,47 @@ def resolve(
             )
         else:
             # cacheless download to memory using an in memory zip file
-            r = requests.get(str(source))
+            r = requests.get(str(source), stream=True)
             r.raise_for_status()
-            if not isinstance(r.content, bytes):
-                raise TypeError(
-                    f"Request content of {source} has unexpected type {type(r.content)}."
-                )
 
             zf = zipfile.ZipFile(io.BytesIO(), "w")
             fn = extract_file_name(source)
-            # alternative implementation; TODO: remove commented code
-            # zf.writestr(fn, r.content)
-            # zp = ZipPath(zf) / fn
-            # assert zp.exists(), f"failed to write {fn} to in-memory zip file"
+            total = int(r.headers.get("content-length", 0))
+
+            if isinstance(progressbar, bool):
+                if progressbar:
+                    use_ascii = bool(sys.platform == "win32")
+                    pbar = tqdm(
+                        total=total,
+                        ncols=79,
+                        ascii=use_ascii,
+                        unit="B",
+                        unit_scale=True,
+                        leave=True,
+                    )
+                    pbar = tqdm(desc=f"Downloading {fn}")
+                else:
+                    pbar = None
+            else:
+                pbar = progressbar
+
             zp = ZipPath(zf, fn)
             with zp.open("wb") as z:
                 assert not isinstance(z, io.TextIOWrapper)
-                _ = z.write(r.content)
+                for chunk in r.iter_content(chunk_size=chunk_size):
+                    n = z.write(chunk)
+                    if pbar is not None:
+                        _ = pbar.update(n)
+
+            # Make sure the progress bar gets filled even if the actual number
+            # is chunks is smaller than expected. This happens when streaming
+            # text files that are compressed by the server when sending (gzip).
+            # Binary files don't experience this.
+            # (adapted from pooch.HttpDownloader)
+            if pbar is not None:
+                pbar.reset()
+                _ = pbar.update(total)
+                pbar.close()
 
             return FileInZip(
                 path=zp,