update known github users

Author: FynnBe

bioimageio/spec/_internal/constants.py

@@ -57,28 +57,30 @@ class _DtypeLimit(NamedTuple):
 )
 
 # TODO: cache/store known gh users in file
-KNOWN_GH_USERS: Set[str] = {
-    "clementcaporal",
-    "donglaiw",
-    "jansanrom",
-    "pedgomgal1",
+KNOWN_GITHUB_USERS: Set[str] = {
     "aaitorg",
+    "anwai98",
     "bioimageiobot",
     "carlosuc3m",
     "cfusterbarcelo",
+    "clementcaporal",
     "constantinpape",
     "ctr26",
     "danifranco",
+    "donglaiw",
     "esgomezm",
     "fynnbe",
     "githubuser2",
     "iarganda",
+    "ilastik",
     "ivanhcenalmor",
     "jansanrom",
     "k-dominik",
     "lenkaback",
     "oeway",
+    "pedgomgal1",
 }
-N_KNOWN_GH_USERS = len(KNOWN_GH_USERS)
-KNOWN_INVALID_GH_USERS: Set[str] = {"arratemunoz", "lmescu"}
-N_KNOWN_INVALID_GH_USERS = len(KNOWN_INVALID_GH_USERS)
+
+N_KNOWN_GITHUB_USERS = len(KNOWN_GITHUB_USERS)
+KNOWN_INVALID_GITHUB_USERS: Set[str] = {"arratemunoz", "lmescu"}
+N_KNOWN_INVALID_GITHUB_USERS = len(KNOWN_INVALID_GITHUB_USERS)

bioimageio/spec/_internal/field_validation.py

@@ -12,7 +12,7 @@
 import httpx
 
 from ._settings import settings
-from .constants import KNOWN_GH_USERS, KNOWN_INVALID_GH_USERS
+from .constants import KNOWN_GITHUB_USERS, KNOWN_INVALID_GITHUB_USERS
 from .field_warning import issue_warning
 from .type_guards import is_mapping, is_sequence, is_tuple
 from .validation_context import get_validation_context
@@ -57,18 +57,20 @@ def validate_unique_entries(seq: Sequence[Hashable]):
     return seq
 
 
-def validate_gh_user(username: str, hotfix_known_errorenous_names: bool = True) -> str:
+def validate_github_user(
+    username: str, hotfix_known_errorenous_names: bool = True
+) -> str:
     if hotfix_known_errorenous_names:
         if username == "Constantin Pape":
             return "constantinpape"
 
     if (
-        username.lower() in KNOWN_GH_USERS
+        username.lower() in KNOWN_GITHUB_USERS
         or not get_validation_context().perform_io_checks
     ):
         return username
 
-    if username.lower() in KNOWN_INVALID_GH_USERS:
+    if username.lower() in KNOWN_INVALID_GITHUB_USERS:
         raise ValueError(f"Known invalid GitHub user '{username}'")
 
     try:
@@ -89,9 +91,9 @@ def validate_gh_user(username: str, hotfix_known_errorenous_names: bool = True)
                 value=username,
             )
         elif r.status_code != 200:
-            KNOWN_INVALID_GH_USERS.add(username.lower())
+            KNOWN_INVALID_GITHUB_USERS.add(username.lower())
             raise ValueError(f"Could not find GitHub user '{username}'")
 
-        KNOWN_GH_USERS.add(username.lower())
+        KNOWN_GITHUB_USERS.add(username.lower())
 
     return username

bioimageio/spec/generic/v0_3.py

@@ -27,7 +27,7 @@
 
 from .._internal.common_nodes import Node, ResourceDescrBase
 from .._internal.constants import TAG_CATEGORIES
-from .._internal.field_validation import validate_gh_user
+from .._internal.field_validation import validate_github_user
 from .._internal.field_warning import as_warning, warn
 from .._internal.io import (
     BioimageioYamlContent,
@@ -112,11 +112,11 @@ class Author(_Author_v0_2):
     github_user: Optional[str] = None
 
     @field_validator("github_user", mode="after")
-    def _validate_gh_user(cls, value: Optional[str]):
+    def _validate_github_user(cls, value: Optional[str]):
         if value is None:
             return None
         else:
-            return validate_gh_user(value)
+            return validate_github_user(value)
 
 
 class _AuthorConv(Converter[_Author_v0_2, Author]):
@@ -140,8 +140,8 @@ class Maintainer(_Maintainer_v0_2):
     github_user: str
 
     @field_validator("github_user", mode="after")
-    def validate_gh_user(cls, value: str):
-        return validate_gh_user(value)
+    def validate_github_user(cls, value: str):
+        return validate_github_user(value)
 
 
 class _MaintainerConv(Converter[_Maintainer_v0_2, Maintainer]):

tests/conftest.py

@@ -8,10 +8,10 @@
 from dotenv import load_dotenv
 
 from bioimageio.spec._internal.constants import (
-    KNOWN_GH_USERS,
-    KNOWN_INVALID_GH_USERS,
-    N_KNOWN_GH_USERS,
-    N_KNOWN_INVALID_GH_USERS,
+    KNOWN_GITHUB_USERS,
+    KNOWN_INVALID_GITHUB_USERS,
+    N_KNOWN_GITHUB_USERS,
+    N_KNOWN_INVALID_GITHUB_USERS,
 )
 from bioimageio.spec._internal.io_utils import read_yaml
 from bioimageio.spec._internal.type_guards import is_dict, is_kwargs
@@ -81,10 +81,10 @@ def unet2d_data(unet2d_path: Path):
 
 
 def pytest_sessionfinish(session: Any, exitstatus: Any):
-    if len(KNOWN_GH_USERS) > N_KNOWN_GH_USERS:
+    if len(KNOWN_GITHUB_USERS) > N_KNOWN_GITHUB_USERS:
         print("updated known gh users:")
-        pprint(KNOWN_GH_USERS)
+        pprint(KNOWN_GITHUB_USERS)
 
-    if len(KNOWN_INVALID_GH_USERS) > N_KNOWN_INVALID_GH_USERS:
+    if len(KNOWN_INVALID_GITHUB_USERS) > N_KNOWN_INVALID_GITHUB_USERS:
         print("updated known invalid gh users:")
-        pprint(KNOWN_INVALID_GH_USERS)
+        pprint(KNOWN_INVALID_GITHUB_USERS)

tests/test_internal/test_constants.py

@@ -28,11 +28,13 @@ def test_warning_levels():
     assert INFO == logging.INFO
 
 
-def test_known_gh_users_are_lowercase():
+def test_known_github_users_are_lowercase():
     from bioimageio.spec._internal.constants import (
-        KNOWN_GH_USERS,
-        KNOWN_INVALID_GH_USERS,
+        KNOWN_GITHUB_USERS,
+        KNOWN_INVALID_GITHUB_USERS,
     )
 
-    assert KNOWN_GH_USERS == {user.lower() for user in KNOWN_GH_USERS}
-    assert KNOWN_INVALID_GH_USERS == {user.lower() for user in KNOWN_INVALID_GH_USERS}
+    assert KNOWN_GITHUB_USERS == {user.lower() for user in KNOWN_GITHUB_USERS}
+    assert KNOWN_INVALID_GITHUB_USERS == {
+        user.lower() for user in KNOWN_INVALID_GITHUB_USERS
+    }

tests/test_internal/test_field_validation.py

@@ -29,14 +29,14 @@ def test_validate_unique_entries():
     assert ret == ["a", "b"]
 
 
-def test_validate_gh_user():
-    from bioimageio.spec._internal.field_validation import validate_gh_user
+def test_validate_github_user():
+    from bioimageio.spec._internal.field_validation import validate_github_user
 
     with pytest.raises(ValueError), ValidationContext(perform_io_checks=True):
-        _ = validate_gh_user("arratemunoz")
+        _ = validate_github_user("arratemunoz")
 
-    cpape = validate_gh_user("Constantin Pape", hotfix_known_errorenous_names=True)
+    cpape = validate_github_user("Constantin Pape", hotfix_known_errorenous_names=True)
     assert cpape == "constantinpape"
 
-    fynnbe = validate_gh_user("fynnbe")
+    fynnbe = validate_github_user("fynnbe")
     assert fynnbe == "fynnbe"

tests/test_specific_reexports_generics.py

@@ -80,7 +80,7 @@
     "v0_3",
     "v0_4",
     "v0_5",
-    "validate_gh_user",
+    "validate_github_user",
     "validate_suffix",
     "ValidatedString",
     "ValidationInfo",