avoid updating status to passed with format validation detail

Author: FynnBe

src/bioimageio/spec/_internal/common_nodes.py

@@ -233,18 +233,22 @@ def load(
             with all_warnings_context:
                 _, _, val_warnings = cls._load_impl(deepcopy_yaml_value(data))
 
+        format_status = "failed" if errors else "passed"
         rd.validation_summary.add_detail(
             ValidationDetail(
                 errors=errors,
                 name=(
                     "bioimageio.spec format validation"
                     f" {rd.type} {cls.implemented_format_version}"
                 ),
-                status="failed" if errors else "passed",
+                status=format_status,
                 warnings=val_warnings,
-                context=context.summary,  # context for format validation detail is identical
-            )
+            ),
+            update_status=False,  # avoid updating status from 'valid-format' to 'passed', but ...
         )
+        if format_status == "failed":
+            # ... update status in case of failure
+            rd.validation_summary.status = "failed"
 
         return rd
 

src/bioimageio/spec/summary.py

@@ -381,14 +381,15 @@ def display(
             include_conda_list=include_conda_list,
         )
 
-    def add_detail(self, detail: ValidationDetail):
-        if self.status == "valid-format" and detail.status == "passed":
-            # once status is valid-format we can only improve to 'passed'
-            self.status = "passed"
-        elif self.status == "passed" and detail.status == "failed":
-            # once status is passed it can only degrade to 'valid-format'
-            self.status = "valid-format"
-        # once format is 'failed' it cannot improve (valid-format is set at summary creation)
+    def add_detail(self, detail: ValidationDetail, update_status: bool = True):
+        if update_status:
+            if self.status == "valid-format" and detail.status == "passed":
+                # once status is 'valid-format' we can only improve to 'passed'
+                self.status = "passed"
+            elif self.status == "passed" and detail.status == "failed":
+                # once status is 'passed' it can only degrade to 'valid-format'
+                self.status = "valid-format"
+            # once format is 'failed' it cannot improve
 
         self.details.append(detail)