Fixed bug - npm package not installing

If user wanted to upgrade an existing package by installing
an npm package. The npm package installed was removed when
other dependencies were installed. This fixes that by removing
the installing logic from validator.js and using a default yeoman
function.

Author: Nikhil-Vats

__tests__/app.js

@@ -158,8 +158,7 @@ describe("generator-biojs-webcomponents:app - Upgrade an existing component by i
 });
 
 describe("generator-biojs-webcomponents:app - Upgrade an existing component by installing component from npm package", () => {
-  it("installs the latest component from its npm package if user enters a valid version", async () => {
-    jest.setTimeout(10000); // Increases timeout for this test
+  it("throws an error if version entered does not exist", async () => {
     let res = await validators.checkVersionAndInstallComponent("latest", {
       packageNameToInstallComponent: "is-odd"
     });

generators/app/index.js

@@ -321,6 +321,7 @@ module.exports = class extends Generator {
             if (props.importFrom === upgradeComponentPrompts[0].choices[0]) {
               return this.prompt(installNpmPackagePrompts).then(props => {
                 // If user chooses to go back and choose source of importing file again
+                this.npmProps = props;
                 if (props.changeImportSourceFromNpmPackage) {
                   return recursivePromptExecution(
                     props.changeImportSourceFromNpmPackage
@@ -469,6 +470,21 @@ module.exports = class extends Generator {
     this.destinationRoot("./");
   }
 
+  installingNPMPackage() {
+    if (
+      this.npmProps &&
+      this.npmProps.packageNameToInstallComponent &&
+      this.npmProps.checkVersionAndInstallComponent
+    ) {
+      this.npmInstall(
+        this.npmProps.packageNameToInstallComponent +
+          "@" +
+          this.npmProps.checkVersionAndInstallComponent,
+        { "save-dev": true }
+      );
+    }
+  }
+
   install() {
     this.installDependencies({
       npm: true,

generators/app/validator.js

@@ -100,51 +100,13 @@ validators.version = async function(props, answers) {
 validators.checkVersionAndInstallComponent = async function(props, answers) {
   if (props) {
     if (props === "latest") {
-      let res = await executeCommand(
-        "cd " +
-          projectDirectory +
-          " && npm i " +
-          answers.packageNameToInstallComponent +
-          "@" +
-          props +
-          " --save-exact",
-        "checkVersionAndInstallComponent"
-      )
-        .then(() => true)
-        .catch(err => {
-          return chalk.red(
-            `Oops! We encountered an error. Please see below for the more details - \n${chalk.yellow(
-              err
-            )}`
-          );
-        });
-      return res;
+      return true;
     }
 
     let command =
       "npm view " + answers.packageNameToInstallComponent + "@" + props;
     let res = await executeCommand(command, "version")
-      .then(async () => {
-        let res = await executeCommand(
-          "cd " +
-            projectDirectory +
-            " && npm i " +
-            answers.packageNameToInstallComponent +
-            "@" +
-            props +
-            " --save-exact",
-          "checkVersionAndInstallComponent"
-        )
-          .then(() => true)
-          .catch(err => {
-            return chalk.red(
-              `Oops! We encountered an error. Please see below for the more details - \n${chalk.yellow(
-                err
-              )}`
-            );
-          });
-        return res;
-      })
+      .then(() => true)
       .catch(() =>
         chalk.red(
           "Sorry, the version - " +
@@ -305,10 +267,7 @@ function executeCommand(command, type) {
         // The command couldn't be executed
         spinner.stop();
         reject(err);
-      } else if (
-        type === "version" ||
-        type === "checkVersionAndInstallComponent"
-      ) {
+      } else if (type === "version") {
         // Command successfully executed
         if (stdout) {
           spinner.stop();