Skip to content

Commit 6a7efdc

Browse files
committed
Extension enforcing in "good" way
I haven't seen it when fixing tests... defaultSuffix Previously solution is bad, because there will pop-up two MessageBox, second when FileDialog is already closed.
1 parent feff7b5 commit 6a7efdc

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

orangecanvas/application/canvasmain.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1549,6 +1549,7 @@ def save_scheme_as(self):
15491549
acceptMode=QFileDialog.AcceptSave,
15501550
windowModality=Qt.WindowModal,
15511551
objectName="save-as-ows-filedialog",
1552+
defaultSuffix=".ows"
15521553
)
15531554
dialog.setNameFilter(self.tr("Orange Workflow (*.ows)"))
15541555
# `deleteLater` can be ivoked before `exec` as PyQt 6.9 doc says, that
@@ -1557,15 +1558,8 @@ def save_scheme_as(self):
15571558
# dialog.exec waits for user action
15581559
if dialog.exec():
15591560
filename = dialog.selectedFiles()[0]
1560-
# Enforcing ".ows" extension during saving file.
1561-
filename = filename if str(filename).endswith('.ows') else f"{filename}.ows"
1562-
do_override = QMessageBox.question(
1563-
self, "Overwrite file?",
1564-
f"File {os.path.split(filename)[1]} already exists."
1565-
"\nOverwrite?"
1566-
) == QMessageBox.Yes if os.path.exists(filename) else True
15671561
settings.setValue("last-scheme-dir", os.path.dirname(filename))
1568-
if do_override and self.save_scheme_to(curr_scheme, filename):
1562+
if self.save_scheme_to(curr_scheme, filename):
15691563
document.setPath(filename)
15701564
document.setModified(False)
15711565
self.add_recent_scheme(curr_scheme.title, document.path())

0 commit comments

Comments
 (0)