Skip to content

Commit 7e84409

Browse files
committed
shtools: Remove universal_newlines parameter override
1 parent 1943a88 commit 7e84409

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

orangecanvas/utils/shtools.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ def create_process(
8181
executable: Optional[str] = None,
8282
stderr=subprocess.STDOUT,
8383
stdout=subprocess.PIPE,
84-
universal_newlines=True,
8584
**kwargs
8685
) -> subprocess.Popen:
8786
"""
@@ -99,7 +98,6 @@ def create_process(
9998
executable=executable,
10099
stderr=stderr,
101100
stdout=stdout,
102-
universal_newlines=universal_newlines,
103101
**kwargs
104102
)
105103

orangecanvas/utils/tests/test_shtools.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
class Test(unittest.TestCase):
99
def test_python_process(self):
10-
p = python_process(["-c", "print('Hello')"])
10+
p = python_process(["-c", "print('Hello')"], encoding="utf-8")
1111
out, _ = p.communicate()
1212
self.assertEqual(out.strip(), "Hello")
1313
self.assertEqual(p.wait(), 0)

0 commit comments

Comments
 (0)