Merge pull request #224 from PrimozGodec/embedding-better-error

Image Embedding - show more descriptive error

Author: PrimozGodec

orangecontrib/imageanalytics/widgets/owimageembedding.py

@@ -2,7 +2,6 @@
 from types import SimpleNamespace
 from typing import Optional
 
-import numpy as np
 from AnyQt.QtCore import Qt
 from AnyQt.QtWidgets import QLayout, QPushButton, QStyle
 
@@ -285,9 +284,8 @@ def on_exception(self, ex: Exception) -> None:
         log = logging.getLogger(__name__)
         log.debug(ex, exc_info=ex)
         self.cancel_button.setDisabled(True)
-        self.Error.unexpected_error(type(ex).__name__)
+        self.Error.unexpected_error(str(ex))
         self.clear_outputs()
-        logging.debug("Exception", exc_info=ex)
 
     def cancel(self):
         self.cancel_button.setDisabled(True)

orangecontrib/imageanalytics/widgets/tests/test_owimageembedding.py

@@ -158,7 +158,7 @@ def test_cancel_embedding(self):
     @mock.patch(
         "orangecontrib.imageanalytics.server_embedder.ServerEmbedder."
         "embedd_data",
-        side_effect=OSError,
+        side_effect=OSError("Connection failed"),
     )
     def test_unexpected_error(self, _):
         """
@@ -175,6 +175,10 @@ def test_unexpected_error(self, _):
         output = self.get_output(self.widget.Outputs.embeddings)
         self.assertIsNone(output)
         self.widget.Error.unexpected_error.is_shown()
+        self.assertEqual(
+            "Embedding error: Connection failed",
+            str(self.widget.Error.unexpected_error),
+        )
 
     @patch(HTTPX_POST_METHOD, regular_dummy_sr)
     def test_rerun_on_new_data(self):