Skip to content

Commit 1562682

Browse files
committed
Network Clustering: Use deferred commit
1 parent 4abac30 commit 1562682

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

orangecontrib/network/widgets/OWNxClustering.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,22 +38,23 @@ def __init__(self):
3838
box = gui.vBox(self.controlArea, "Label Propagation")
3939
gui.spin(
4040
box, self, "iterations", 1, 100000, 1,
41-
label="Max. iterations: ", callback=self.commit)
41+
label="Max. iterations: ", callback=self.commit.deferred)
4242
gui.doubleSpin(box, self, "hop_attenuation", 0, 1, 0.01,
4343
label="Apply hop attenuation: ",
44-
checked="attenuate", callback=self.commit,
45-
checkCallback=self.commit)
44+
checked="attenuate", callback=self.commit.deferred,
45+
checkCallback=self.commit.deferred)
4646
self.random_state = gui.checkBox(
4747
box, self, "use_random_state",
48-
label="Replicable clustering", callback=self.commit)
48+
label="Replicable clustering", callback=self.commit.deferred)
4949

5050
gui.auto_apply(self.controlArea, self)
5151

5252
@Inputs.network
5353
def set_network(self, net):
5454
self.net = net
55-
self.commit()
55+
self.commit.now()
5656

57+
@gui.deferred
5758
def commit(self):
5859
kwargs = {'iterations': self.iterations}
5960
if self.attenuate:

orangecontrib/network/widgets/tests/test_OWNxClustering.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def test_does_not_crash_when_cluster_variable_already_exists(self):
2828

2929
# Should not crash
3030
self.send_signal(self.widget.Inputs.network, graph)
31-
self.widget.unconditional_commit()
31+
self.widget.commit.now()
3232

3333
# There should be an additional cluster column
3434
output = self.get_output(self.widget.Outputs.network).nodes
@@ -39,11 +39,11 @@ def test_reproducible_clustering(self):
3939
self.widget.controls.use_random_state.setChecked(True)
4040

4141
self.send_signal(self.widget.Inputs.network, network)
42-
self.widget.unconditional_commit()
42+
self.widget.commit.now()
4343
res1 = self.get_output(self.widget.Outputs.network).nodes.metas
4444

4545
self.send_signal(self.widget.Inputs.network, network)
46-
self.widget.unconditional_commit()
46+
self.widget.commit.now()
4747
res2 = self.get_output(self.widget.Outputs.network).nodes.metas
4848

4949
# Seeded rerun should give same clustering result
@@ -55,7 +55,7 @@ def test_multiple_reruns_override_variable(self):
5555

5656
for _ in range(10):
5757
self.send_signal(self.widget.Inputs.network, network)
58-
self.widget.unconditional_commit()
58+
self.widget.commit.now()
5959

6060
output = self.get_output(self.widget.Outputs.network).nodes
6161
# Multiple reruns should override the results instead of adding new feature every time

0 commit comments

Comments
 (0)