distinguish server vs internet issues

Author: leskovecg

orangecontrib/text/tests/test_owdocumentembedding.py

@@ -0,0 +1,72 @@
+import pytest
+from orangecontrib.text.vectorization.document_embedder import DocumentEmbedder
+from orangecontrib.text import Corpus
+from Orange.misc.utils.embedder_utils import EmbeddingConnectionError
+from orangecontrib.text.vectorization.document_embedder import _ServerEmbedder
+from urllib.parse import urlparse
+import socket
+
+@pytest.fixture
+def dummy_corpus():
+    return Corpus.from_documents(["This is a test document."], name="test")
+
+def test_embedding_valid_server(dummy_corpus):
+    embedder = DocumentEmbedder(language="en", aggregator="Mean")
+    new_corpus, skipped = embedder._transform(dummy_corpus, None)
+    assert new_corpus is not None
+    assert skipped is None or len(skipped) == 0
+
+def test_invalid_server_raises(dummy_corpus):
+    class BrokenEmbedder(DocumentEmbedder):
+        def _transform(self, corpus, _, callback=None):
+
+            embedder = _ServerEmbedder(
+                aggregator="mean",
+                model_name="fasttext-en",
+                max_parallel_requests=100,
+                server_url="https://api.invalidserver.io",
+                embedder_type="text",
+            )
+
+            url = urlparse(embedder.server_url)
+            host, port = url.hostname, url.port or (443 if url.scheme == "https" else 80)
+            try:
+                socket.create_connection((host, port), timeout=3)
+            except Exception as e:
+                raise EmbeddingConnectionError("The server is not responding") from e
+
+            return [], None
+
+    embedder = BrokenEmbedder(language="en", aggregator="Mean")
+    with pytest.raises(EmbeddingConnectionError, match="server is not responding"):
+        embedder._transform(dummy_corpus, None)
+
+def test_no_internet_raises(dummy_corpus, monkeypatch):
+    class NoInternetEmbedder(DocumentEmbedder):
+        def _transform(self, corpus, _, callback=None):
+
+            embedder = _ServerEmbedder(
+                aggregator="mean",
+                model_name="fasttext-en",
+                max_parallel_requests=100,
+                server_url="https://api.garaza.io",
+                embedder_type="text",
+            )
+
+            def raise_os_error(*args, **kwargs):
+                raise OSError("Simulated: No internet connection")
+
+            monkeypatch.setattr("socket.create_connection", raise_os_error)
+
+            url = urlparse(embedder.server_url)
+            host, port = url.hostname, url.port or (443 if url.scheme == "https" else 80)
+            try:
+                socket.create_connection((host, port), timeout=3)
+            except Exception as e:
+                raise EmbeddingConnectionError("No internet connection") from e
+
+            return [], None
+
+    embedder = NoInternetEmbedder(language="en", aggregator="Mean")
+    with pytest.raises(EmbeddingConnectionError, match="No internet connection"):
+        embedder._transform(dummy_corpus, None)

orangecontrib/text/vectorization/document_embedder.py

@@ -16,6 +16,10 @@
 from orangecontrib.text import Corpus
 from orangecontrib.text.vectorization.base import BaseVectorizer
 
+from Orange.misc.utils.embedder_utils import EmbeddingConnectionError
+import socket
+from urllib.parse import urlparse
+
 AGGREGATORS = ["mean", "sum", "max", "min"]
 AGGREGATORS_ITEMS = ['Mean', 'Sum', 'Max', 'Min']
 # fmt: off
@@ -87,10 +91,36 @@ def _transform(
             server_url="https://api.garaza.io",
             embedder_type="text",
         )
-        embs = embedder.embedd_data(
-            list(corpus.ngrams) if isinstance(corpus, Corpus) else corpus,
-            callback=callback,
-        )
+
+        try:
+            url = urlparse(embedder.server_url)
+            host, port = url.hostname, url.port or (443 if url.scheme == "https" else 80)
+
+            try:
+                sock = socket.create_connection((host, port), timeout=3)
+                sock.close()
+            except socket.gaierror as e:
+                try:
+                    socket.gethostbyname("example.com")
+                    raise ConnectionError("The server is not responding (bad hostname)") from e
+                except socket.gaierror:
+                    raise OSError("No internet connection (DNS failure)") from e
+            except (ConnectionRefusedError, socket.timeout, OSError):
+                raise ConnectionError("The server is not responding (socket check)")
+
+            embs = embedder.embedd_data(
+                list(corpus.ngrams) if isinstance(corpus, Corpus) else corpus,
+                callback=callback,
+            )
+            if not embs or all(e is None for e in embs):
+                raise ConnectionError("The server is not responding (no embeddings returned)")
+
+        except OSError as e:
+            raise EmbeddingConnectionError("No internet connection") from e
+        except ConnectionError as e:
+            raise EmbeddingConnectionError("The server is not responding") from e
+        except Exception as e:
+            raise EmbeddingConnectionError(f"Unknown network error: {e}") from e
 
         if isinstance(corpus, list):
             return embs
@@ -167,4 +197,4 @@ async def _encode_data_instance(self, data_instance: Any) -> Optional[bytes]:
 if __name__ == '__main__':
     with DocumentEmbedder(language='en', aggregator='Max') as embedder:
         embedder.clear_cache()
-        embedder(Corpus.from_file('deerwester'))
+        embedder(Corpus.from_file('deerwester'))

orangecontrib/text/widgets/owdocumentembedding.py

@@ -1,11 +1,12 @@
 from typing import Dict, Optional, Any
-
 from AnyQt.QtCore import Qt
 from AnyQt.QtWidgets import QVBoxLayout, QPushButton, QStyle
 from Orange.misc.utils.embedder_utils import EmbeddingConnectionError
 from Orange.widgets import gui
 from Orange.widgets.settings import Setting
 from Orange.widgets.widget import Msg, Output, OWWidget
+import os 
+import socket
 
 from orangecontrib.text.corpus import Corpus
 from orangecontrib.text.language import (
@@ -50,8 +51,10 @@ class Outputs(OWBaseVectorizer.Outputs):
 
     class Error(OWWidget.Error):
         no_connection = Msg(
-            "No internet connection. Please establish a connection or use "
-            "another vectorizer."
+        "No internet connection. Please establish a connection or use another vectorizer."
+        )
+        server_unresponsive = Msg(
+            "The server at {server} is not responding. Please check the address or try again later."
         )
         unexpected_error = Msg("Embedding error: {}")
 
@@ -150,8 +153,23 @@ def on_done(self, result):
     def on_exception(self, ex: Exception):
         self.cancel_button.setDisabled(True)
         if isinstance(ex, EmbeddingConnectionError):
-            self.Error.no_connection()
+            # check basic internet connectivity (attempt connection to 8.8.8.8:53)
+            internet_available = False
+            try:
+                socket.create_connection(("8.8.8.8", 53), timeout=3)
+                internet_available = True
+            except OSError:
+                internet_available = False
+
+            if internet_available:
+                # internet works → the server may be invalid or unresponsive
+                server_url = os.getenv("ORANGE_EMBEDDING_API_URL", "https://api.garaza.io")
+                self.Error.server_unresponsive(server=server_url)
+            else:
+                # general lack of internet connection
+                self.Error.no_connection()
         else:
+             # delegate other errors to the original handler
             self.Error.unexpected_error(str(ex))
         self.cancel()
 
@@ -190,4 +208,4 @@ def send_report(self):
 if __name__ == "__main__":
     from orangewidget.utils.widgetpreview import WidgetPreview
 
-    WidgetPreview(OWDocumentEmbedding).run(Corpus.from_file("book-excerpts"))
+    WidgetPreview(OWDocumentEmbedding).run(Corpus.from_file("book-excerpts"))