owkmeans: fix initialization choice

Author: markotoplak

Orange/widgets/unsupervised/owkmeans.py

@@ -316,7 +316,7 @@ def __launch_tasks(self, ks):
             self._compute_clustering,
             data=self.data,
             k=k,
-            init=['random', 'k-means++'][self.smart_init],
+            init=['k-means++', 'random'][self.smart_init],
             n_init=self.n_init,
             max_iter=self.max_iterations,
             silhouette=True,

Orange/widgets/unsupervised/tests/test_owkmeans.py

@@ -411,6 +411,21 @@ def test_do_not_recluster_on_same_data(self):
             self.commit_and_wait()
             self.assertEqual(call_count + 1, commit.call_count)
 
+    def test_correct_smart_init(self):
+        # due to a bug where wrong init was passed to _compute_clustering
+        self.send_signal(self.widget.Inputs.data, self.iris[::10], wait=5000)
+        self.widget.smart_init = 0
+        with patch.object(self.widget, "_compute_clustering",
+                          wraps=self.widget._compute_clustering) as compute:
+            self.commit_and_wait()
+            self.assertEqual(compute.call_args[1]['init'], "k-means++")
+        self.widget.invalidate()  # reset caches
+        self.widget.smart_init = 1
+        with patch.object(self.widget, "_compute_clustering",
+                          wraps=self.widget._compute_clustering) as compute:
+            self.commit_and_wait()
+            self.assertEqual(compute.call_args[1]['init'], "random")
+
 
 if __name__ == "__main__":
     unittest.main()